Skip to content

treewide: remove more cruft and add some improvements

Bartosz Golaszewski linux-gpio 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 6 repliesIn review
  2. v16 patches 15 repliesSuperseded

Changes in v2 from the cover letter

- rename BIAS_NONE to BIAS_UNKNOWN
- rename DRIVE_NONE to DRIVE_PUSH_PULL
- rename BIAS_DISABLE to BIAS_DISABLED

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7treewide: remove helpers for opening chips by name & numberbindings/cxx/chip.cpp bindings/cxx/gpiod.hpp bindings/cxx/tests/tests-chip.cpp +16 more+167 -4190 replies
2/7treewide: simplify the active-low line propertybindings/cxx/examples/gpioinfocxx.cpp bindings/cxx/gpiod.hpp bindings/cxx/line.cpp +8 more+69 -1350 replies
3/7treewide: rename BIAS_AS_IS to BIAS_UNKNOWNbindings/cxx/gpiod.hpp bindings/cxx/line.cpp bindings/cxx/tests/tests-line.cpp +5 more+23 -233 replies
4/7treewide: rename BIAS_DISABLE to BIAS_DISABLEDbindings/cxx/gpiod.hpp bindings/cxx/line.cpp bindings/cxx/line_bulk.cpp +9 more+32 -320 replies
5/7treewide: make drive settings an enumbindings/cxx/gpiod.hpp bindings/cxx/line.cpp bindings/cxx/tests/tests-line.cpp +6 more+134 -1320 replies
6/7bindings: cxx: line: reorder bias mapping entriesbindings/cxx/line.cpp+2 -20 replies
7/7core: add the kernel uapi header to the repositoryconfigure.ac lib/Makefile.am lib/core.c +1 more+528 -112 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [libgpiod][PATCH v2 0/7] treewide: remove more cruft and add some improvements

From: Bartosz Golaszewski <[email protected]>

This is another batch of improvements to libgpiod before we overhaul the data structure model.

The last patch adds the kernel uapi header to the repository so that we no longer depend on its presence on the host system.

v1 -> v2:
- rename BIAS_NONE to BIAS_UNKNOWN
- rename DRIVE_NONE to DRIVE_PUSH_PULL
- rename BIAS_DISABLE to BIAS_DISABLED

Bartosz Golaszewski (7):
treewide: remove helpers for opening chips by name & number
treewide: simplify the active-low line property
treewide: rename BIAS_AS_IS to BIAS_UNKNOWN
treewide: rename BIAS_DISABLE to BIAS_DISABLED
treewide: make drive settings an enum
bindings: cxx: line: reorder bias mapping entries
core: add the kernel uapi header to the repository

 bindings/cxx/chip.cpp                  |  41 +-
 bindings/cxx/examples/gpioinfocxx.cpp  |   3 +-
 bindings/cxx/gpiod.hpp                 |  61 +--
 bindings/cxx/line.cpp                  |  28 +-
 bindings/cxx/line_bulk.cpp             |   4 +-
 bindings/cxx/tests/tests-chip.cpp      |  97 +----
 bindings/cxx/tests/tests-event.cpp     |  14 +-
 bindings/cxx/tests/tests-iter.cpp      |   2 +-
 bindings/cxx/tests/tests-line.cpp      |  97 ++---
 bindings/python/examples/gpioinfo.py   |   4 +-
 bindings/python/gpiodmodule.c          | 187 +++------
 bindings/python/tests/gpiod_py_test.py | 177 ++++-----
 configure.ac                           |  12 +-
 include/gpiod.h                        |  69 +---
 lib/Makefile.am                        |   2 +-
 lib/core.c                             |  35 +-
 lib/helpers.c                          |  57 ---
 lib/uapi/gpio.h                        | 522 +++++++++++++++++++++++++
 tests/tests-chip.c                     |  41 --
 tests/tests-event.c                    |   2 +-
 tests/tests-line.c                     | 110 +++---
 tools/gpiodetect.c                     |   2 +-
 tools/gpiofind.c                       |   2 +-
 tools/gpioget.c                        |   2 +-
 tools/gpioinfo.c                       |  30 +-
 tools/gpiomon.c                        |   2 +-
 tools/gpioset.c                        |   2 +-
 tools/tools-common.c                   |  59 ++-
 tools/tools-common.h                   |   3 +
 29 files changed, 934 insertions(+), 733 deletions(-)
 create mode 100644 lib/uapi/gpio.h
Signature · 1 line
2.29.1