Skip to content

Scan for an idle sibling in a single pass

Mel Gorman lkml 5 versions – Applied

Status from this message: The following commit has been merged into the sched/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 2 repliesApplied
  2. v44 patches 7 repliesApplied
  3. v35 patches 15 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches4 repliesSuperseded
v15 patches8 repliesSuperseded

Changes in v5 from the cover letter

o Avoid use of intermediate variable during select_idle_cpu

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/4sched/fair: Remove SIS_AVG_CPUkernel/sched/fair.c kernel/sched/features.h+9 -120 replies
2/4sched/fair: Move avg_scan_cost calculations under SIS_PROPkernel/sched/fair.c+8 -60 replies
3/4sched/fair: Remove select_idle_smt()kernel/sched/fair.c+0 -300 replies
4/4sched/fair: Merge select_idle_core/cpu()kernel/sched/fair.c+59 -400 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchVincent Guittot
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/4] Scan for an idle sibling in a single pass

Changelog since v4
o Avoid use of intermediate variable during select_idle_cpu

Changelog since v3
o Drop scanning based on cores, SMT4 results showed problems

Changelog since v2
o Remove unnecessary parameters
o Update nr during scan only when scanning for cpus

Changlog since v1
o Move extern declaration to header for coding style
o Remove unnecessary parameter from __select_idle_cpu

This series of 4 patches reposts three patches from Peter entitled "select_idle_sibling() wreckage". It only scans the runqueues in a single pass when searching for an idle sibling.

Three patches from Peter were dropped. The first patch altered how scan depth was calculated. Scan depth deletion is a random number generator with two major limitations. The avg_idle time is based on the time between a CPU going idle and being woken up clamped approximately by 2*sysctl_sched_migration_cost. This is difficult to compare in a sensible fashion to avg_scan_cost. The second issue is that only the avg_scan_cost of scan failures is recorded and it does not decay. This requires deeper surgery that would justify a patch on its own although Peter notes that
https://lkml.kernel.org/r/[email protected] is potentially useful for an alternative avg_idle metric.

The second patch dropped scanned based on cores instead of CPUs as it rationalised the difference between core scanning and CPU scanning. Unfortunately, Vincent reported problems with SMT4 so it's dropped for now until depth searching can be fixed.

The third patch dropped converted the idle core scan throttling mechanism to SIS_PROP. While this would unify the throttling of core and CPU scanning, it was not free of regressions and has_idle_cores is a fairly effective throttling mechanism with the caveat that it can have a lot of false positives for workloads like hackbench.

Peter's series tried to solve three problems at once, this subset addresses one problem.

 kernel/sched/fair.c     | 151 +++++++++++++++++++---------------------
 kernel/sched/features.h |   1 -
 2 files changed, 70 insertions(+), 82 deletions(-)
Signature · 14 lines
2.26.2

Mel Gorman (4):
  sched/fair: Remove SIS_AVG_CPU
  sched/fair: Move avg_scan_cost calculations under SIS_PROP
  sched/fair: Remove select_idle_smt()
  sched/fair: Merge select_idle_core/cpu()

 kernel/sched/fair.c     | 151 +++++++++++++++++++---------------------
 kernel/sched/features.h |   1 -
 2 files changed, 70 insertions(+), 82 deletions(-)

-- 
2.26.2