Skip to content

fs: deduplicate compat logic

Willem de Bruijn linux-fsdevel lkml oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6selftests/filesystems: add initial select and poll selftesttools/testing/selftests/filesystems/.gitignore tools/testing/selftests/filesystems/Makefile tools/testing/selftests/filesystems/selectpoll.c+209 -10 replies
2/6select: deduplicate compat logicfs/select.c+57 -1970 replies
3/6ppoll: deduplicate compat logicfs/select.c+30 -610 replies
4/6epoll: deduplicate compat logicfs/eventpoll.c+9 -290 replies
5/6compat: add set_maybe_compat_user_sigmask helperfs/eventpoll.c fs/io_uring.c fs/select.c +1 more+14 -200 replies
6/6io_pgetevents: deduplicate compat logicfs/aio.c+37 -570 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] fs: deduplicate compat logic

From: Willem de Bruijn <[email protected]>

Use in_compat_syscall() to differentiate compat handling exactly where needed, including in nested function calls. Then remove duplicated code in callers.

Changes
RFC[1]->v1
- remove kselftest dependency on variant support in teardown (patch is out for review, not available in linux-next/akpm yet)
- add patch 5: deduplicate set_user_sigmask compat handling
- add patch 6: deduplicate io_pgetevents sigmask compat handling

[1] RFC: https://github.com/wdebruij/linux-next-mirror/tree/select-compat-1

Willem de Bruijn (6):
selftests/filesystems: add initial select and poll selftest
select: deduplicate compat logic
ppoll: deduplicate compat logic
epoll: deduplicate compat logic
compat: add set_maybe_compat_user_sigmask helper
io_pgetevents: deduplicate compat logic

 fs/aio.c                                      |  94 ++---
 fs/eventpoll.c                                |  35 +-
 fs/io_uring.c                                 |   9 +-
 fs/select.c                                   | 339 +++++-------------
 include/linux/compat.h                        |  10 +
 .../testing/selftests/filesystems/.gitignore  |   1 +
 tools/testing/selftests/filesystems/Makefile  |   2 +-
 .../selftests/filesystems/selectpoll.c        | 207 +++++++++++
 8 files changed, 344 insertions(+), 353 deletions(-)
 create mode 100644 tools/testing/selftests/filesystems/selectpoll.c
Signature · 1 line
2.30.0.284.gd98b1dd5eaa7-goog