Skip to content

iotests: Fix 129 and expand 297’s reach

Max Reitz qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest10 patches 6 repliesIn review
  2. v410 patches 9 repliesSuperseded
  3. v310 patches 18 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v28 patches12 repliesSuperseded

Changes in v5 from the cover letter

- Patch 2:
- Construct PYTHONPATH/MYPYPATH platform-independently
- Use os.pathsep instead of hard-coding ':'
- Use os.path.dirname(__file__) as the basis for '../../python' instead of adding a relative path to PYTHONPATH
- Use os.path.join() instead of joining with '/'

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10iotests.py: Assume a couple of variables as giventests/qemu-iotests/300 tests/qemu-iotests/iotests.py+13 -141 reply
2/10iotests/297: Rewrite in Python and extend reachtests/qemu-iotests/297 tests/qemu-iotests/297.out+92 -254 replies
3/10iotests: Move try_remove to iotests.pytests/qemu-iotests/124 tests/qemu-iotests/iotests.py+8 -111 reply
4/10iotests/129: Remove test images in tearDown()tests/qemu-iotests/129+2 -00 replies
5/10iotests/129: Do not check @busytests/qemu-iotests/129+1 -10 replies
6/10iotests/129: Use throttle nodetests/qemu-iotests/129+13 -240 replies
7/10iotests/129: Actually test a commit jobtests/qemu-iotests/129+25 -20 replies
8/10iotests/129: Limit mirror job's buffer sizetests/qemu-iotests/129+1 -10 replies
9/10iotests/129: Clean up pylint and mypy complaintstests/qemu-iotests/129 tests/qemu-iotests/297+3 -30 replies
10/10iotests/300: Clean up pylint and mypy complaintstests/qemu-iotests/297 tests/qemu-iotests/300+16 -40 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchVladimir Sementsov-OgievskiyWillian RampazzoEric BlakeJohn Snow
1/10R-b R-b R-b
2/10R-b R-b
3/10R-b R-b R-b R-b
4/10R-b R-b R-b
5/10R-b R-b R-b
6/10R-b R-b R-b
7/10R-b R-b R-b
8/10R-b R-b R-b
9/10R-b R-b
10/10R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/10] iotests: Fix 129 and expand 297’s reach

Cover letters:
v1: https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00254.html
v2: https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00296.html
v3: https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00371.html
v4: https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00371.html

git:
https://github.com/XanClic/qemu.git fix-129-2-v5
https://git.xanclic.moe/XanClic/qemu.git fix-129-2-v5

Change in v5 (from v4):
- Patch 2:
- Construct PYTHONPATH/MYPYPATH platform-independently
- Use os.pathsep instead of hard-coding ':'
- Use os.path.dirname(__file__) as the basis for '../../python' instead of adding a relative path to PYTHONPATH
- Use os.path.join() instead of joining with '/'

git-backport-diff of v4 <-> v5:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/10:[----] [--] 'iotests.py: Assume a couple of variables as given' 002/10:[0006] [FC] 'iotests/297: Rewrite in Python and extend reach' 003/10:[----] [--] 'iotests: Move try_remove to iotests.py' 004/10:[----] [--] 'iotests/129: Remove test images in tearDown()' 005/10:[----] [--] 'iotests/129: Do not check @busy' 006/10:[----] [--] 'iotests/129: Use throttle node' 007/10:[----] [--] 'iotests/129: Actually test a commit job' 008/10:[----] [--] 'iotests/129: Limit mirror job's buffer size' 009/10:[----] [--] 'iotests/129: Clean up pylint and mypy complaints' 010/10:[----] [--] 'iotests/300: Clean up pylint and mypy complaints'

Max Reitz (10):
iotests.py: Assume a couple of variables as given iotests/297: Rewrite in Python and extend reach
iotests: Move try_remove to iotests.py iotests/129: Remove test images in tearDown() iotests/129: Do not check @busy iotests/129: Use throttle node iotests/129: Actually test a commit job iotests/129: Limit mirror job's buffer size iotests/129: Clean up pylint and mypy complaints iotests/300: Clean up pylint and mypy complaints

 tests/qemu-iotests/124        |   8 +--
 tests/qemu-iotests/129        |  72 +++++++++++++---------
 tests/qemu-iotests/297        | 112 +++++++++++++++++++++++++++-------
 tests/qemu-iotests/297.out    |   5 +-
 tests/qemu-iotests/300        |  19 ++++--
 tests/qemu-iotests/iotests.py |  37 +++++------
 6 files changed, 171 insertions(+), 82 deletions(-)
Signature · 1 line
2.29.2