Skip to content

UBSan Enablement for hyp/nVHE code

Elena Petrova kvmarm linux-arm-kernel lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 4 repliesIn review
  2. v29 patches 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9KVM: arm64: Enable UBSan instrumentation in nVHE hyp codearch/arm64/kvm/hyp/nvhe/Makefile arch/arm64/kvm/hyp/nvhe/ubsan.c+32 -11 reply
2/9KVM: arm64: Add a buffer that can pass UBSan data from hyp/nVHE to kernelarch/arm64/include/asm/assembler.h arch/arm64/include/asm/kvm_debug_buffer.h arch/arm64/include/asm/kvm_host.h +6 more+146 -11 reply
3/9KVM: arm64: Enable UBSAN_BOUNDS for the both the kernel and hyp/nVHEarch/arm64/include/asm/kvm_ubsan.h arch/arm64/kvm/hyp/nvhe/ubsan.c arch/arm64/kvm/kvm_ubsan_buffer.c+40 -31 reply
4/9KVM: arm64: Enable UBsan check for unreachable code inside hyp/nVHE codearch/arm64/include/asm/kvm_ubsan.h arch/arm64/kvm/hyp/nvhe/ubsan.c arch/arm64/kvm/kvm_ubsan_buffer.c+17 -10 replies
5/9KVM: arm64: Enable shift out of bounds undefined behaviour check for hyp/nVHEarch/arm64/include/asm/kvm_ubsan.h arch/arm64/kvm/hyp/nvhe/ubsan.c arch/arm64/kvm/kvm_ubsan_buffer.c+21 -20 replies
6/9KVM: arm64: __ubsan_handle_load_invalid_value EL2 implementation.arch/arm64/include/asm/kvm_ubsan.h arch/arm64/kvm/hyp/nvhe/ubsan.c arch/arm64/kvm/kvm_ubsan_buffer.c+22 -30 replies
7/9KVM: arm64: Detect type mismatch undefined behaviour from hyp/nVHE codearch/arm64/include/asm/kvm_ubsan.h arch/arm64/kvm/hyp/nvhe/ubsan.c arch/arm64/kvm/kvm_ubsan_buffer.c+48 -40 replies
8/9KVM: arm64: Detect arithmetic overflow is inside hyp/nVHE.arch/arm64/include/asm/kvm_ubsan.h arch/arm64/kvm/hyp/nvhe/ubsan.c arch/arm64/kvm/kvm_ubsan_buffer.c+62 -80 replies
9/9KVM: arm64: Add UBSan tests for PKVM.arch/arm64/include/asm/assembler.h arch/arm64/include/asm/kvm_debug_buffer.h arch/arm64/include/asm/kvm_ubsan.h +3 more+128 -171 reply

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchDavid Brazdil
1/9A-b
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/9] UBSan Enablement for hyp/nVHE code

Respin of George's patch series enabling UBSAN for hyp/nVHE code.

Updates in v3:
* rebased onto v5.11-rc3
* added base commit info

Updates in v2:
* CONFIG_KVM_ARM_DEBUG_BUFFER removed; __kvm_check_ubsan_buffer is called directly instead of via __kvm_arm_check_debug_buffer.
* Bugfixing commits removed as these are already upstream.
* Some code brought up to date, i.e. moved from entry.S to host.S.
* Merged "Add support for creating and checking a buffer" and "Add a buffer that can pass UBSan data from hyp/nVHE" into one commit as these changes don't work without each other.

George Popescu (9):
KVM: arm64: Enable UBSan instrumentation in nVHE hyp code
KVM: arm64: Add a buffer that can pass UBSan data from hyp/nVHE to
kernel
KVM: arm64: Enable UBSAN_BOUNDS for the both the kernel and hyp/nVHE
KVM: arm64: Enable UBsan check for unreachable code inside hyp/nVHE
code
KVM: arm64: Enable shift out of bounds undefined behaviour check for
hyp/nVHE
KVM: arm64: __ubsan_handle_load_invalid_value EL2 implementation.
KVM: arm64: Detect type mismatch undefined behaviour from hyp/nVHE
code
KVM: arm64: Detect arithmetic overflow is inside hyp/nVHE.
KVM: arm64: Add UBSan tests for PKVM.

 arch/arm64/include/asm/assembler.h          |  10 ++
 arch/arm64/include/asm/kvm_debug_buffer.h   |  34 ++++
 arch/arm64/include/asm/kvm_host.h           |   8 +-
 arch/arm64/include/asm/kvm_ubsan.h          |  50 ++++++
 arch/arm64/kvm/Makefile                     |   2 +
 arch/arm64/kvm/arm.c                        |   9 ++
 arch/arm64/kvm/hyp/include/hyp/test_ubsan.h | 112 +++++++++++++
 arch/arm64/kvm/hyp/nvhe/Makefile            |   3 +-
 arch/arm64/kvm/hyp/nvhe/host.S              |   4 +
 arch/arm64/kvm/hyp/nvhe/hyp-main.c          |   3 +
 arch/arm64/kvm/hyp/nvhe/ubsan.c             | 164 ++++++++++++++++++++
 arch/arm64/kvm/kvm_ubsan_buffer.c           |  81 ++++++++++
 12 files changed, 478 insertions(+), 2 deletions(-)
 create mode 100644 arch/arm64/include/asm/kvm_debug_buffer.h
 create mode 100644 arch/arm64/include/asm/kvm_ubsan.h
 create mode 100644 arch/arm64/kvm/hyp/include/hyp/test_ubsan.h
 create mode 100644 arch/arm64/kvm/hyp/nvhe/ubsan.c
 create mode 100644 arch/arm64/kvm/kvm_ubsan_buffer.c

base-commit: 5ee88057889bbca5f5bb96031b62b3756b33e164

Signature · 6 lines
2.30.0.296.g2bfb1c46d8-goog

_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm