Skip to content

VMX: more nested fixes

Maxim Levitsky kvm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest3 patches 11 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3KVM: nVMX: Always call sync_vmcs02_to_vmcs12_rare on migrationarch/x86/kvm/vmx/nested.c+8 -52 replies
2/3KVM: nVMX: add kvm_nested_vmlaunch_resume tracepointarch/x86/kvm/trace.h arch/x86/kvm/vmx/nested.c arch/x86/kvm/x86.c+37 -06 replies
3/3KVM: VMX: read idt_vectoring_info a bit earlierarch/x86/kvm/vmx/vmx.c+2 -12 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchSean Christopherson
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] VMX: more nested fixes

This is hopefully the last fix for VMX nested migration
that finally allows my stress test of migration with a nested guest to pass.

In a nutshell after an optimization that was done in commit 7952d769c29ca, some of vmcs02 fields which can be modified by the L2 freely while it runs (like GSBASE and such) were not copied back to vmcs12 unless:

1. L1 tries to vmread them (update done on intercept)
2. vmclear or vmldptr on other vmcs are done.
3. nested state is read and nested guest is running.

What wasn't done was to sync these 'rare' fields when L1 is running but still has a loaded vmcs12 which might have some stale fields, if that vmcs was used to enter a guest already due to that optimization.

Plus I added two minor patches to improve VMX tracepoints a bit. There is still a large room for improvement.

Best regards,
Maxim Levitsky

Maxim Levitsky (3):
KVM: nVMX: Always call sync_vmcs02_to_vmcs12_rare on migration
KVM: nVMX: add kvm_nested_vmlaunch_resume tracepoint
KVM: VMX: read idt_vectoring_info a bit earlier

 arch/x86/kvm/trace.h      | 30 ++++++++++++++++++++++++++++++
 arch/x86/kvm/vmx/nested.c | 19 ++++++++++++++-----
 arch/x86/kvm/vmx/vmx.c    |  3 ++-
 arch/x86/kvm/x86.c        |  1 +
 4 files changed, 47 insertions(+), 6 deletions(-)
Signature · 1 line
2.26.2