Skip to content

sim: validate IMS private identity

Sergey Matyukevich ofono 3 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 2 repliesApplied
  2. v21 patch 4 repliesSuperseded
  3. v11 patch 3 repliesSuperseded

Changes in v3 from the cover letter

- support both null-terminated and non-null terminated TLV values
- move validation helper into simutil.c
- add unit tests

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3simutil: add validate_utf8_tlvsrc/simutil.c src/simutil.h+15 -01 reply
2/3sim: validate IMS private identitysrc/sim.c+2 -11 reply
3/3unit: add validate_utf8_tlv testsunit/test-simutil.c+22 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3] sim: validate IMS private identity

Hello Denis and all,

These patches add UTF8 validation for IMS private identity. Without this check ofono may crash on dbus assert when SIM properties are reported via org.ofono.SimManager interface.

Regards,
Sergey

v2 -> v3

- support both null-terminated and non-null terminated TLV values
- move validation helper into simutil.c
- add unit tests

Sergey Matyukevich (3):
simutil: add validate_utf8_tlv
sim: validate IMS private identity
unit: add validate_utf8_tlv tests

 src/sim.c           |  3 ++-
 src/simutil.c       | 14 ++++++++++++++
 src/simutil.h       |  1 +
 unit/test-simutil.c | 22 ++++++++++++++++++++++
 4 files changed, 39 insertions(+), 1 deletion(-)