Skip to content

Tests for overlayfs immutable/append-only files

Amir Goldstein fstests linux-unionfs 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 0 repliesNew
  2. v14 patches 11 repliesSuperseded

Changes in v2 from the cover letter

- Split the dangerous test
- Document fix commit
- Fix Eryu's minor review comments on t_immutable

[1] https://lore.kernel.org/linux-fsdevel/[email protected]/

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5overlay/030: Update comment w.r.t upstream kerneltests/overlay/030+5 -20 replies
2/5src/t_immutable: factor out some helperssrc/t_immutable.c+104 -1170 replies
3/5src/t_immutable: Allow setting flags on existing filessrc/t_immutable.c+24 -60 replies
4/5overlay: Test lost immutable/append-only flags on copy-uptests/overlay/075 tests/overlay/075.out tests/overlay/group+104 -00 replies
5/5overlay: Regression test for deadlock on directory ioctltests/overlay/076 tests/overlay/076.out tests/overlay/group+69 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/5] Tests for overlayfs immutable/append-only files

Eryu,

Overlayfs never had full support for immutable/append-only files. Whatever works is covered by generic/079 and overlay/030 tests. Both tests cover only upper files and directories. generic/079 is notrun on kernel < 5.10 and passes on >= 5.10.

This series improves the t_immutable test program and adds two new tests.

overlay/075 tests immutable/append-only lower files and directories - the test fails on upstream kernel. Fixing this requires some VFS API changes that Miklos has proposed [1].

overlay/076 is a "dangerous" test that triggers a deadlock. The deadlock was fixed in master and in stable kernel v5.10.15.

Thanks,
Amir.

Changes since v1:
- Split the dangerous test
- Document fix commit
- Fix Eryu's minor review comments on t_immutable

[1] https://lore.kernel.org/linux-fsdevel/[email protected]/

Amir Goldstein (5):
overlay/030: Update comment w.r.t upstream kernel src/t_immutable: factor out some helpers src/t_immutable: Allow setting flags on existing files
overlay: Test lost immutable/append-only flags on copy-up
overlay: Regression test for deadlock on directory ioctl

 src/t_immutable.c     | 241 +++++++++++++++++++++---------------------
 tests/overlay/030     |   7 +-
 tests/overlay/075     |  92 ++++++++++++++++
 tests/overlay/075.out |  11 ++
 tests/overlay/076     |  66 ++++++++++++
 tests/overlay/076.out |   2 +
 tests/overlay/group   |   2 +
 7 files changed, 301 insertions(+), 120 deletions(-)
 create mode 100755 tests/overlay/075
 create mode 100644 tests/overlay/075.out
 create mode 100644 tests/overlay/076
 create mode 100644 tests/overlay/076.out
Signature · 1 line
2.25.1