Skip to content

hw/usb/dev-uas: Fix Clang 11 -Wgnu-variable-sized-type-not-at-end error

Philippe Mathieu-Daudé qemu-devel 2 versions – Applied

Status from this message: Queued 2+3, fixup #2 conflicts due to dropping #1.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 5 repliesApplied
  2. v1 RFC2 patches 7 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3scsi/utils: Rename 'illegal request' -> 'invalid request'include/scsi/utils.h scsi/utils.c+20 -203 replies
2/3scsi/utils: Add INVALID_PARAM_VALUE sense code definitioninclude/scsi/utils.h scsi/utils.c+7 -00 replies
3/3hw/usb/dev-uas: Report command additional adb length as unsupportedhw/usb/dev-uas.c+11 -12 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchEric Blake
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] hw/usb/dev-uas: Fix Clang 11 -Wgnu-variable-sized-type-not-at-end error

Another attempt to fix the following Clang 11 warning:

usb/dev-uas.c:157:31: error: field 'status' with variable sized type 'uas_i=
u' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-vari= able-sized-type-not-at-end]

      uas_iu                    status;
                                ^

If a guest send a packet with additional data, respond with "Invalid Request - parameter not supported".

v2: Include Eric feedbacks

Philippe Mathieu-Daud=C3=A9 (3):
scsi/utils: Rename 'illegal request' -> 'invalid request' scsi/utils: Add INVALID_PARAM_VALUE sense code definition hw/usb/dev-uas: Report command additional adb length as unsupported

 include/scsi/utils.h | 22 ++++++++++++----------
 hw/usb/dev-uas.c     | 12 +++++++++++-
 scsi/utils.c         | 25 +++++++++++++++----------
 3 files changed, 38 insertions(+), 21 deletions(-)

--=20
2.26.2