Skip to content

builtin/pack-objects.c: avoid iterating all refs

Jacob Vosmaer git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest1 patch 9 repliesIn review
  2. v11 patch 11 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1builtin/pack-objects.c: avoid iterating all refsbuiltin/pack-objects.c+3 -59 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchTaylor Blau
1/1R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/1] builtin/pack-objects.c: avoid iterating all refs

I have updated the patch with more background information in the commit message, and I have cleaned up the add_ref_tag iterator callback a bit. I also switched to for_each_tag_ref.

On the previous version of the patch there was some discussion about whether we can use for_each_tag_ref in combination with peel_ref. It turns out we can, and we were already doing it in the same file:
search for mark_tagged to see what I mean.

Jacob Vosmaer (1):
builtin/pack-objects.c: avoid iterating all refs

 builtin/pack-objects.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
Signature · 1 line
2.30.0