Skip to content

Console/stdio use after free

Pratyush Yadav u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Console/stdio use after free
Quoted 15 lines · Simon Glass

Hi Nicolas,

Quoted 11 lines · Nicolas Saenz Julienne

With today's master, 70c2525c0d3c ('IOMUX: Stop dropped consoles') introduces a use after free in usb_kbd_remove():

- usbkbd's stdio device is de-registered with stdio_deregister_dev(), the struct stdio_dev is freed.

- iomux_doenv() is called, usbkbd removed from the console list, and console_stop() is called on the struct stdio_dev pointer that no longer exists.

Quoted 6 lines
Quoted 3 lines

This series mitigates this by making sure the pointer is really a stdio device prior performing the stop operation. It's not ideal, but I couldn't figure out a nicer way to fix this.

Your 'from' address is coming through as just your email. Could you please update it to include your name as well?

From shows the full name on my email client. For everybody apart from Nicholas it shows just the email, but for Nicholas I can see full name in both From and Cc.

Maybe something wrong with your email client settings.

Quoted 2 lines

Regards,
Simon

Signature · 3 lines
Regards,
Pratyush Yadav
Texas Instruments India