Skip to content

net: ipa: NAPI poll updates

Alex Elder lkml netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (refs/heads/master):

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 0 repliesApplied 5/5
  2. v15 patches 2 repliesSuperseded

Patches in v2 All 5 applied

#Subject and filesSizeRepliesApplied
1/5net: ipa: count actual work done in gsi_channel_poll()drivers/net/ipa/gsi.c+2 -30 repliesApplied
2/5net: ipa: heed napi_complete() return valuedrivers/net/ipa/gsi.c+1 -30 repliesApplied
3/5net: ipa: have gsi_channel_update() return a valuedrivers/net/ipa/gsi.c+6 -70 repliesApplied
4/5net: ipa: repurpose gsi_irq_ieob_disable()drivers/net/ipa/gsi.c+12 -70 repliesApplied
5/5net: ipa: disable IEOB interrupts before clearingdrivers/net/ipa/gsi.c+1 -10 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH net-next v2 0/5] net: ipa: NAPI poll updates

Version 1 of this series inadvertently dropped the "static" that limits the scope of gsi_channel_update(). Version 2 fixes this (in patch 3).

While reviewing the IPA NAPI polling code in detail I found two problems. This series fixes those, and implements a few other improvements to this part of the code.

The first two patches are minor bug fixes that avoid extra passes through the poll function. The third simplifies code inside the polling loop a bit.

The last two update how interrupts are disabled; previously it was possible for another I/O completion condition to be recorded before NAPI got scheduled.

-Alex

Alex Elder (5):
net: ipa: count actual work done in gsi_channel_poll()
net: ipa: heed napi_complete() return value
net: ipa: have gsi_channel_update() return a value
net: ipa: repurpose gsi_irq_ieob_disable()
net: ipa: disable IEOB interrupts before clearing

 drivers/net/ipa/gsi.c | 41 +++++++++++++++++++++--------------------
 1 file changed, 21 insertions(+), 20 deletions(-)
Signature · 1 line
2.20.1