Skip to content

json test case fixups

Florian Westphal netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4json: fix icmpv6.t test casestests/py/ip6/icmpv6.t.json tests/py/ip6/icmpv6.t.json.output+597 -161 reply
2/4json: limit: set default burst to 5src/parser_json.c+1 -14 replies
3/4json: ct: add missing ruletests/py/ip/ct.t.json+30 -01 reply
4/4json: icmp: refresh json outputtests/py/ip/icmp.t.json+568 -801 reply

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchPhil Sutter
1/4A-b
2/4
3/4A-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH nft 0/4] json test case fixups

json tests fail in several cases because test files were out of data. This refreshs them.

One bug is genuine: in limit statement, json parser should treat a missing burst as 5, not 0.

Florian Westphal (4):
json: fix icmpv6.t test cases
json: limit: set default burst to 5
json: ct: add missing rule
json: icmp: refresh json output

 src/parser_json.c                 |   2 +-
 tests/py/ip/ct.t.json             |  30 ++
 tests/py/ip/icmp.t.json           | 648 ++++++++++++++++++++++++++----
 tests/py/ip6/icmpv6.t.json        |  27 +-
 tests/py/ip6/icmpv6.t.json.output | 586 ++++++++++++++++++++++++++-
 5 files changed, 1196 insertions(+), 97 deletions(-)
Signature · 1 line
2.26.2