Skip to content

fix 'max-pkt-len' errors

Steve Yang dpdk-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 4 repliesIn review
  2. v33 patches 4 repliesSuperseded

Changes in v4 from the cover letter

* combined testpmd patches;
* updated the commit log for patch 2;

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ethdev: fix MTU doesn't update when jumbo frame disabledlib/librte_ethdev/rte_ethdev.c+4 -41 reply
2/2app/testpmd: fix max-pkt-len option invalidapp/test-pmd/cmdline.c app/test-pmd/parameters.c app/test-pmd/testpmd.c +1 more+50 -173 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLance RichardsonWisam JaddoXiaoyun LiChen, BoX C
SeriesA-b A-b A-b A-b A-b A-b T-b T-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [dpdk-dev] [PATCH v4 0/2] fix 'max-pkt-len' errors

Here fixed 3 issues for 'max-pkt-len':
1. When cmdline option '--max-pkt-len' set the value less then '1500 + overhead', the app/testpmd will force to resize the 'max-pkt-len' to '1500 + overhead'. However, the user really want to configure 'max-pkt-len' to a specified value (< 1500 + overhead);

2. If the large value of '--max-pkt-len' gave (e.g.: 8000), and user want to reset the value to a small one (e.g.: 1400), it will became invalid due to JUMBO_FRAME offload state doesn't change before port started;

3. When rx/tx queue offloads capabilities aren't specified, the rx/tx queue setup will be failed once the port offloads changed.

---
v4:
* combined testpmd patches;
* updated the commit log for patch 2;
v3:
* rebased code to latest;
* splited to 3 commits;

v2:
* moved the update logic to 'rxtx_port_config';
* added the 'tx_conf' part;
* optimized the 'default' assignment;
---

Steve Yang (2):
ethdev: fix MTU doesn't update when jumbo frame disabled app/testpmd: fix max-pkt-len option invalid

 app/test-pmd/cmdline.c         |  1 +
 app/test-pmd/parameters.c      |  1 +
 app/test-pmd/testpmd.c         | 63 +++++++++++++++++++++++++---------
 app/test-pmd/testpmd.h         |  2 ++
 lib/librte_ethdev/rte_ethdev.c |  8 ++---
 5 files changed, 54 insertions(+), 21 deletions(-)
Signature · 1 line
2.17.1