Skip to content

RFC ceph: convert buffered read codepaths to new netfs API

Jeff Layton ceph-devel linux-fsdevel lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6ceph: disable old fscache readpage handlingfs/ceph/addr.c fs/ceph/cache.c fs/ceph/cache.h +1 more+3 -2510 replies
2/6ceph: rework PageFsCache handlingfs/ceph/addr.c+7 -10 replies
3/6ceph: fix invalidationfs/ceph/caps.c fs/ceph/inode.c+2 -00 replies
4/6ceph: convert readpage to fscache read helperfs/ceph/Kconfig fs/ceph/addr.c fs/ceph/cache.h+176 -100 replies
5/6ceph: plug write_begin into read helperfs/ceph/addr.c+61 -1260 replies
6/6ceph: convert ceph_readpages to ceph_readaheadfs/ceph/addr.c+34 -1950 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/6] ceph: convert buffered read codepaths to new netfs API

This patchset coverts ceph to use the new netfs API that David Howells has proposed [1]. It's a substantial reduction in code in the ceph layer itself, but the main impetus is to allow the VM, filesystem and fscache to better work together to optimize readahead on network filesystems.

I think the resulting code is also easier to understand, and should be more maintainable as a lot of the pagecache handling is now done at the netfs layer.

This has been lightly tested with xfstests. With fscache disabled, I saw no regressions. With fscache enabled, I still hit some bugs down in the fscache layer itself, but those seem to be present without this set as well. This doesn't seem to make any of that worse.

[1]: https://lore.kernel.org/ceph-devel/[email protected]/T/#t

Jeff Layton (6):
ceph: disable old fscache readpage handling
ceph: rework PageFsCache handling
ceph: fix invalidation
ceph: convert readpage to fscache read helper
ceph: plug write_begin into read helper
ceph: convert ceph_readpages to ceph_readahead

 fs/ceph/Kconfig |   1 +
 fs/ceph/addr.c  | 536 +++++++++++++++++++-----------------------------
 fs/ceph/cache.c | 123 -----------
 fs/ceph/cache.h | 101 +++------
 fs/ceph/caps.c  |  10 +-
 fs/ceph/inode.c |   1 +
 6 files changed, 236 insertions(+), 536 deletions(-)
Signature · 1 line
2.29.2