Skip to content

support for 256 VFs in RTM_GETLINK

Edwin Peer netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 20 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4netlink: truncate overlength attribute list in nla_nest_end()include/net/netlink.h include/uapi/linux/netlink.h lib/nlattr.c+37 -216 replies
2/4rtnetlink: extend RTEXT_FILTER_SKIP_STATS to IFLA_VF_INFOnet/core/rtnetlink.c+51 -452 replies
3/4rtnetlink: refactor IFLA_VF_INFO stats into rtnl_fill_vfstats()net/core/rtnetlink.c+38 -280 replies
4/4rtnetlink: promote IFLA_VF_STATS to same level as IFLA_VF_INFOinclude/uapi/linux/if_link.h include/uapi/linux/rtnetlink.h net/core/rtnetlink.c+23 -32 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/4] support for 256 VFs in RTM_GETLINK

RTM_GETLINK for greater than about 220 VFs truncates IFLA_VFINFO_LIST due to the maximum reach of nlattr's nla_len being exceeded. There is not a lot of enthusiasm for extensive fixes to the deprecated netlink ABI for VF config, but there appears to be even less appetite for the kinds of work arounds that would be necessitated in order to truly keep it frozen [1].

This series first addresses nla_nest_end()'s propensity to generate malformed netlink messages. The balance of the series comprises very minor ABI updates intended to be low impact, in order to address the remaining issues. First, the existing RTEXT_FILTER_SKIP_STATS is called upon to alleviate the problem when user space does not want statistics and then a minor tweak is introduced in two steps in order to promote the stats one level up in the hierarchy with the minimum of code churn.

Finally, the kernel series is followed by an iproute2 series to take advantage of the changes.

[1] https://lore.kernel.org/netdev/[email protected]/

Edwin Peer (4):
netlink: truncate overlength attribute list in nla_nest_end()
rtnetlink: extend RTEXT_FILTER_SKIP_STATS to IFLA_VF_INFO
rtnetlink: refactor IFLA_VF_INFO stats into rtnl_fill_vfstats()
rtnetlink: promote IFLA_VF_STATS to same level as IFLA_VF_INFO

 include/net/netlink.h          |  11 ++-
 include/uapi/linux/if_link.h   |   1 +
 include/uapi/linux/netlink.h   |   1 +
 include/uapi/linux/rtnetlink.h |   1 +
 lib/nlattr.c                   |  27 +++++++
 net/core/rtnetlink.c           | 132 +++++++++++++++++++++------------
 6 files changed, 122 insertions(+), 51 deletions(-)
Signature · 1 line
2.30.0