Skip to content

io_uring: add support for IORING_OP_GETDENTS

Lennert Buytenhek io-uring linux-fsdevel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 4 repliesIn review
  2. v42 patches 1 replySuperseded
  3. v32 patches 10 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC1 patch15 repliesSuperseded

Changes in v5 from the cover letter

- Make IORING_OP_GETDENTS read from the directory's current position if the specified offset value is -1 (IORING_FEAT_RW_CUR_POS). (Requested / pointed out by Tavian Barnes.)

- Rebase onto for-5.13/io_uring as of 2021/03/30 plus v3 of Dmitry Kadashev's "io_uring: add mkdirat support".

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2readdir: split the core of getdents64(2) out into vfs_getdents()fs/readdir.c include/linux/fs.h+21 -80 replies
2/2io_uring: add support for IORING_OP_GETDENTSfs/io_uring.c include/uapi/linux/io_uring.h+67 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/2] io_uring: add support for IORING_OP_GETDENTS

(These patches depend on IORING_OP_MKDIRAT going in first.)

These patches add support for IORING_OP_GETDENTS, which is a new io_uring opcode that more or less does an lseek(sqe->fd, sqe->off, SEEK_SET) followed by a getdents64(sqe->fd, (void *)sqe->addr, sqe->len).

A dumb test program which recursively scans through a directory tree and prints the names of all directories and files it encounters along the way is available here:

https://krautbox.wantstofly.org/~buytenh/uringfind-v3.c

Changes since v4:

- Make IORING_OP_GETDENTS read from the directory's current position if the specified offset value is -1 (IORING_FEAT_RW_CUR_POS). (Requested / pointed out by Tavian Barnes.)

- Rebase onto for-5.13/io_uring as of 2021/03/30 plus v3 of Dmitry Kadashev's "io_uring: add mkdirat support".

Changes since v3:

- Made locking in io_getdents() unconditional, as the prior optimization was racy. (Pointed out by Pavel Begunkov.)

- Rebase onto for-5.13/io_uring as of 2021/03/12 plus a manually applied version of the mkdirat patch.

Changes since v2 RFC:

- Rebase onto io_uring-2021-02-17 plus a manually applied version of the mkdirat patch. The latter is needed because userland (liburing) has already merged the opcode for IORING_OP_MKDIRAT (in commit "io_uring.h: 5.12 pending kernel sync") while this opcode isn't in the kernel yet (as of io_uring-2021-02-17), and this means that this can't be merged until IORING_OP_MKDIRAT is merged.

- Adapt to changes made in "io_uring: replace force_nonblock with flags" that are in io_uring-2021-02-17.

Changes since v1 RFC:

- Drop the trailing '64' from IORING_OP_GETDENTS64 (suggested by Matthew Wilcox).

- Instead of requiring that sqe->off be zero, use this field to pass in a directory offset to start reading from. For the first IORING_OP_GETDENTS call on a directory, this can be set to zero, and for subsequent calls, it can be set to the ->d_off field of the last struct linux_dirent64 returned by the previous call.

Lennert Buytenhek (2):
readdir: split the core of getdents64(2) out into vfs_getdents()
io_uring: add support for IORING_OP_GETDENTS

 fs/io_uring.c                 |   66 ++++++++++++++++++++++++++++++++++++++++++
 fs/readdir.c                  |   25 ++++++++++-----
 include/linux/fs.h            |    4 ++
 include/uapi/linux/io_uring.h |    1
 4 files changed, 88 insertions(+), 8 deletions(-)