V4L2 Async notifier API cleanup
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest13 patches 10 repliesIn review
- v414 patches 7 repliesSuperseded
- v314 patches 12 repliesSuperseded
Changes in v5 from the cover letter
- Merge the two async documentation patches; rework documentation a little.
- Fix compile error in pxa_camera.c.
- Assign ret in mipi_csis_async_register on error path.
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | media: v4l2-async: Clean v4l2_async_notifier_add_fwnode_remote_subdevdrivers/ drivers/ drivers/ +9 more | +96 | 0 replies | |
| 2/13 | media: atmel: Use v4l2_async_notifier_add_fwnode_remote_subdevdrivers/ drivers/ drivers/ | +29 | 0 replies | |
| 3/13 | media: stm32: Use v4l2_async_notifier_add_fwnode_remote_subdevdrivers/ | +30 | 0 replies | |
| 4/13 | media: exynos4-is: Use v4l2_async_notifier_add_fwnode_remote_subdevdrivers/ drivers/ | +14 | 0 replies | |
| 5/13 | media: st-mipid02: Use v4l2_async_notifier_add_fwnode_remote_subdevdrivers/ | +10 | 0 replies | |
| 6/13 | media: cadence: Use v4l2_async_notifier_add_fwnode_remote_subdevdrivers/ | +6 | 0 replies | |
| 7/13 | media: marvell-ccic: Use v4l2_async_notifier_add_*_subdevdrivers/ drivers/ drivers/ +1 more | +19 | 0 replies | |
| 8/13 | media: renesas-ceu: Use v4l2_async_notifier_add_*_subdevdrivers/ | +27 | 0 replies | |
| 9/13 | media: pxa-camera: Use v4l2_async_notifier_add_*_subdevdrivers/ | +23 | 0 replies | |
| 10/13 | media: davinci: vpif_display: Remove unused v4l2-async codedrivers/ drivers/ include/ | +15 | 0 replies | |
| 11/13 | media: v4l2-async: Discourage use of v4l2_async_notifier_add_subdevdrivers/ drivers/ include/ | +12 | 4 replies | |
| 12/13 | media: v4l2-async: Improve v4l2_async_notifier_add_*_subdev() APIdrivers/ drivers/ drivers/ +30 more | +113 | 0 replies | |
| 13/13 | media: Clarify v4l2-async subdevice addition APIDocumentation/ include/ | +50 | 2 replies | |
| 13/13 | media: Clarify v4l2-async subdevice addition APIDocumentation/ include/ | +50 | 4 replies |
Reviews trailers per patch
All 14 patches have a Reviewed-by or Acked-by.
| Patch | Jacopo Mondi | Helen Koike | Laurent Pinchart | Niklas Söderlund |
|---|---|---|---|---|
| 1/13 | R-b | R-b | ||
| 2/13 | R-b | R-b | ||
| 3/13 | R-b | R-b | ||
| 4/13 | R-b | R-b | ||
| 5/13 | R-b | R-b | ||
| 6/13 | R-b | R-b | ||
| 7/13 | R-b | R-b | ||
| 8/13 | R-b | R-b | ||
| 9/13 | R-b | |||
| 10/13 | R-b | |||
| 11/13 | R-b | R-b | ||
| 12/13 | R-b | R-b | R-b | |
| 13/13 | R-b | R-b R-b | ||
| 13/13 | R-b | R-b R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v5 00/13] V4L2 Async notifier API cleanup
Hi all,
I took Ezequiel's set (after discussing with him) and made changes on top of v2 based on the review comments.
The goal of this series is to make the API more consistent, also fixing all the drivers which are currently misusing the API.
With this change, the v4l2-async functions that add subdevices to a notifier have the same semantics, that is they all allocate a struct v4l2_async_subdev, and take a size argument for drivers to embed struct v4l2_async_subdev in a larger struct.
This makes the struct v4l2_async_subdev allocation model more consistent, and simpler to understand.
The V4L2 sub-devices documentation, as well as the kernel-doc are also improved a bit, clarifying the API.
Finally, all the drivers previously using v4l2_async_notifier_add_subdev are converted to proper helpers, which allows us to rename v4l2_async_notifier_add_subdev to __v4l2_async_notifier_add_subdev, and clarify the documentation so hopefully future drivers will avoid it.
I have tried to convert the drivers in the least invasive way, keeping the original code as much as possible. In many cases, specially the old drivers, there is some bitrot and some room for more cleanups, which is beyond the scope of this patchset.
The series is now rebased on top of these patches:
media: v4l2-async: Remove V4L2_ASYNC_MATCH_CUSTOM
media: v4l2-async: Remove V4L2_ASYNC_MATCH_DEVNAME
media: pxa_camera: Drop the v4l2-clk clock register
media: imx6-mipi-csi2: Call remote subdev get_mbus_config to get active lanes
Since v4:
- Merge the two async documentation patches; rework documentation a little.
- Fix compile error in pxa_camera.c.
- Assign ret in mipi_csis_async_register on error path.
Since v3:
- Forgot to mention rebase on current linux-media master for v3, i.e. actually since v2.
- Make the documentation patch last, and adjust it to cover Laurent's previously last patch of async API improvements.
- Move async API changes to the right patch (from 11th -> 1st).
- Assign ret in rkisp1_subdev_notifier.
- Use negative error value in
__v4l2_async_notifier_add_fwnode_remote_subdev.
- Fix functions listed in v4l2_async_notifier_unregister and v4l2_async_notifier_register documentation, removing v4l2_async_register_subdev_sensor_common and adding v4l2_async_notifier_add_fwnode_remote_subdev. I hope this is fine now...
- Fix async API usage and compilation in max9286, rkisp1 and st-mipid02 driver.
Since v2:
- Don't do useless assign of ret before returning in drivers/media/i2c/st-mipid02.c or drivers/media/platform/renesas-ceu.c.
- Don't do of_node_put(NULL) in
drivers/media/platform/exynos4-is/media-dev.c.
- Fix comment in drivers/media/v4l2-core/v4l2-async.c.
- List all current driver API functions used for working with async notifiers in v4l2_async_notifier_init() and v4l2_async_notifier_cleanup() kerneldoc documentation in include/media/v4l2-async.h.
Changes from v1:
* Add Laurent's follow cleanup, which makes the API safer.
* Fix commit description s/is discouraged/will be discouraged
* Fix missing allocation in renesas-ceu driver.
* Fix missing of_node puts in exynos4-is driver.
* Rework mention of v4l2_fwnode_reference_parse_sensor_common
Ezequiel Garcia (13):
media: v4l2-async: Clean v4l2_async_notifier_add_fwnode_remote_subdev
media: atmel: Use v4l2_async_notifier_add_fwnode_remote_subdev
media: stm32: Use v4l2_async_notifier_add_fwnode_remote_subdev
media: exynos4-is: Use v4l2_async_notifier_add_fwnode_remote_subdev
media: st-mipid02: Use v4l2_async_notifier_add_fwnode_remote_subdev
media: cadence: Use v4l2_async_notifier_add_fwnode_remote_subdev
media: marvell-ccic: Use v4l2_async_notifier_add_*_subdev
media: renesas-ceu: Use v4l2_async_notifier_add_*_subdev
media: pxa-camera: Use v4l2_async_notifier_add_*_subdev
media: davinci: vpif_display: Remove unused v4l2-async code
media: v4l2-async: Fix incorrect comment
media: v4l2-async: Discourage use of v4l2_async_notifier_add_subdev
media: Clarify v4l2-async subdevice addition API
Laurent Pinchart (1):
media: v4l2-async: Improve v4l2_async_notifier_add_*_subdev() API
.../driver-api/media/v4l2-subdev.rst | 41 +++++++-- drivers/media/i2c/max9286.c | 14 +-- drivers/media/i2c/st-mipid02.c | 21 +++-- drivers/media/pci/intel/ipu3/ipu3-cio2-main.c | 15 ++-- drivers/media/platform/am437x/am437x-vpfe.c | 2 +- drivers/media/platform/atmel/atmel-isc.h | 1 + drivers/media/platform/atmel/atmel-isi.c | 46 +++------- .../media/platform/atmel/atmel-sama5d2-isc.c | 44 ++++------ drivers/media/platform/cadence/cdns-csi2rx.c | 17 ++-- drivers/media/platform/davinci/vpif_capture.c | 2 +- drivers/media/platform/davinci/vpif_display.c | 86 ++++-------------- drivers/media/platform/davinci/vpif_display.h | 1 - drivers/media/platform/exynos4-is/media-dev.c | 25 +++--- drivers/media/platform/exynos4-is/media-dev.h | 2 +- .../media/platform/marvell-ccic/cafe-driver.c | 14 ++- .../media/platform/marvell-ccic/mcam-core.c | 10 --- .../media/platform/marvell-ccic/mcam-core.h | 1 - .../media/platform/marvell-ccic/mmp-driver.c | 11 ++- drivers/media/platform/omap3isp/isp.c | 74 ++++++---------- drivers/media/platform/pxa_camera.c | 53 +++++------ drivers/media/platform/qcom/camss/camss.c | 11 +-- drivers/media/platform/rcar-vin/rcar-core.c | 5 +- drivers/media/platform/rcar-vin/rcar-csi2.c | 2 +- drivers/media/platform/rcar_drif.c | 2 +- drivers/media/platform/renesas-ceu.c | 56 +++++------- .../platform/rockchip/rkisp1/rkisp1-dev.c | 15 ++-- drivers/media/platform/stm32/stm32-dcmi.c | 87 +++++++------------ .../platform/sunxi/sun4i-csi/sun4i_csi.c | 9 +- .../platform/sunxi/sun4i-csi/sun4i_csi.h | 1 - drivers/media/platform/ti-vpe/cal.c | 12 ++- drivers/media/platform/video-mux.c | 14 +-- drivers/media/platform/xilinx/xilinx-vipp.c | 10 +-- drivers/media/v4l2-core/v4l2-async.c | 54 ++++++------ drivers/media/v4l2-core/v4l2-fwnode.c | 6 +- drivers/staging/media/imx/imx-media-csi.c | 14 +-- drivers/staging/media/imx/imx-media-of.c | 2 +- drivers/staging/media/imx/imx6-mipi-csi2.c | 19 ++-- drivers/staging/media/imx/imx7-media-csi.c | 16 ++-- drivers/staging/media/imx/imx7-mipi-csis.c | 15 +--- drivers/staging/media/tegra-video/vi.c | 10 +-- include/media/davinci/vpif_types.h | 2 - include/media/v4l2-async.h | 64 +++++++++----- 42 files changed, 380 insertions(+), 526 deletions(-)
Signature · 68 lines
2.29.2 Ezequiel Garcia (12): media: v4l2-async: Clean v4l2_async_notifier_add_fwnode_remote_subdev media: atmel: Use v4l2_async_notifier_add_fwnode_remote_subdev media: stm32: Use v4l2_async_notifier_add_fwnode_remote_subdev media: exynos4-is: Use v4l2_async_notifier_add_fwnode_remote_subdev media: st-mipid02: Use v4l2_async_notifier_add_fwnode_remote_subdev media: cadence: Use v4l2_async_notifier_add_fwnode_remote_subdev media: marvell-ccic: Use v4l2_async_notifier_add_*_subdev media: renesas-ceu: Use v4l2_async_notifier_add_*_subdev media: pxa-camera: Use v4l2_async_notifier_add_*_subdev media: davinci: vpif_display: Remove unused v4l2-async code media: v4l2-async: Discourage use of v4l2_async_notifier_add_subdev media: Clarify v4l2-async subdevice addition API Laurent Pinchart (1): media: v4l2-async: Improve v4l2_async_notifier_add_*_subdev() API .../driver-api/media/v4l2-subdev.rst | 48 ++++++++-- drivers/media/i2c/max9286.c | 14 +-- drivers/media/i2c/st-mipid02.c | 21 +++-- drivers/media/pci/intel/ipu3/ipu3-cio2-main.c | 15 ++-- drivers/media/platform/am437x/am437x-vpfe.c | 2 +- drivers/media/platform/atmel/atmel-isc.h | 1 + drivers/media/platform/atmel/atmel-isi.c | 46 +++------- .../media/platform/atmel/atmel-sama5d2-isc.c | 44 ++++------ drivers/media/platform/cadence/cdns-csi2rx.c | 17 ++-- drivers/media/platform/davinci/vpif_capture.c | 2 +- drivers/media/platform/davinci/vpif_display.c | 86 ++++-------------- drivers/media/platform/davinci/vpif_display.h | 1 - drivers/media/platform/exynos4-is/media-dev.c | 25 +++--- drivers/media/platform/exynos4-is/media-dev.h | 2 +- .../media/platform/marvell-ccic/cafe-driver.c | 14 ++- .../media/platform/marvell-ccic/mcam-core.c | 10 --- .../media/platform/marvell-ccic/mcam-core.h | 1 - .../media/platform/marvell-ccic/mmp-driver.c | 11 ++- drivers/media/platform/omap3isp/isp.c | 74 ++++++---------- drivers/media/platform/pxa_camera.c | 57 +++++------- drivers/media/platform/qcom/camss/camss.c | 11 +-- drivers/media/platform/rcar-vin/rcar-core.c | 5 +- drivers/media/platform/rcar-vin/rcar-csi2.c | 2 +- drivers/media/platform/rcar_drif.c | 2 +- drivers/media/platform/renesas-ceu.c | 56 +++++------- .../platform/rockchip/rkisp1/rkisp1-dev.c | 15 ++-- drivers/media/platform/stm32/stm32-dcmi.c | 87 +++++++------------ .../platform/sunxi/sun4i-csi/sun4i_csi.c | 9 +- .../platform/sunxi/sun4i-csi/sun4i_csi.h | 1 - drivers/media/platform/ti-vpe/cal.c | 12 ++- drivers/media/platform/video-mux.c | 14 +-- drivers/media/platform/xilinx/xilinx-vipp.c | 10 +-- drivers/media/v4l2-core/v4l2-async.c | 54 ++++++------ drivers/media/v4l2-core/v4l2-fwnode.c | 6 +- drivers/staging/media/imx/imx-media-csi.c | 14 +-- drivers/staging/media/imx/imx-media-of.c | 2 +- drivers/staging/media/imx/imx6-mipi-csi2.c | 19 ++-- drivers/staging/media/imx/imx7-media-csi.c | 16 ++-- drivers/staging/media/imx/imx7-mipi-csis.c | 15 ++-- drivers/staging/media/tegra-video/vi.c | 10 +-- include/media/davinci/vpif_types.h | 2 - include/media/v4l2-async.h | 64 +++++++++----- 42 files changed, 386 insertions(+), 531 deletions(-) -- 2.29.2