Skip to content

net: ipa: hardware pipeline cleanup fixes

Alex Elder lkml netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (refs/heads/master):

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 1 replyApplied 6/6
  2. v16 patches 2 repliesSuperseded

Patches in v2 All 6 applied

#Subject and filesSizeRepliesApplied
1/6net: ipa: rename "tag status" symbolsdrivers/net/ipa/ipa_cmd.c drivers/net/ipa/ipa_cmd.h drivers/net/ipa/ipa_endpoint.c+28 -210 repliesApplied
2/6net: ipa: minor update to handling of packet with statusdrivers/net/ipa/ipa_endpoint.c+17 -130 repliesApplied
3/6net: ipa: drop packet if status has valid tagdrivers/net/ipa/ipa_endpoint.c+16 -20 repliesApplied
4/6net: ipa: signal when tag transfer completesdrivers/net/ipa/ipa.h drivers/net/ipa/ipa_cmd.c drivers/net/ipa/ipa_cmd.h +2 more+45 -10 repliesApplied
5/6net: ipa: don't pass tag value to ipa_cmd_ip_tag_status_add()drivers/net/ipa/ipa_cmd.c+4 -40 repliesApplied
6/6net: ipa: don't pass size to ipa_cmd_transfer_add()drivers/net/ipa/ipa_cmd.c+2 -40 repliesApplied

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchWillem de Bruijn
SeriesA-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 0/6] net: ipa: hardware pipeline cleanup fixes

Version 2 of this series fixes a "restricted __le16 degrades to integer" warning from sparse in the third patch. The normal host architecture is little-endian, so the problem did not produce incorrect behavior, but the code was wrong not to perform the endianness conversion. The updated patch uses le16_get_bits() to properly extract the value of the field we're interested in.

Everything else remains the same. Below is the original description.

-Alex

There is a procedure currently referred to as a "tag process" that is performed to clear the IPA hardware pipeline--either at the time of a modem crash, or when suspending modem GSI channels.

One thing done in this procedure is issuing a command that sends a data packet originating from the AP->command TX endpoint, destined for the AP<-LAN RX (default) endpoint. And although we currently wait for the send to complete, we do *not* wait for the packet to be received. But the pipeline can't be assumed clear until we have actually received this packet.

This series addresses this by detecting when the pipeline-clearing packet has been received, and using a completion to allow a waiter to know when that has happened. This uses the IPA status capability (which sends an extra status buffer for certain packets). It also uses the ability to supply a "tag" with a packet, which will be delivered with the packet's status buffer. We tag the data packet that's sent to clear the pipeline, and use the receipt of a status buffer associated with a tagged packet to determine when that packet has arrived.

"Tag status" just desribes one aspect of this procedure, so some symbols are renamed to be more like "pipeline clear" so they better describe the larger purpose. Finally, two functions used in this code don't use their arguments, so those arguments are removed.

-Alex

Alex Elder (6):
net: ipa: rename "tag status" symbols
net: ipa: minor update to handling of packet with status
net: ipa: drop packet if status has valid tag
net: ipa: signal when tag transfer completes
net: ipa: don't pass tag value to ipa_cmd_ip_tag_status_add()
net: ipa: don't pass size to ipa_cmd_transfer_add()

 drivers/net/ipa/ipa.h          |  2 +
 drivers/net/ipa/ipa_cmd.c      | 45 +++++++++++++------
 drivers/net/ipa/ipa_cmd.h      | 24 ++++++-----
 drivers/net/ipa/ipa_endpoint.c | 79 ++++++++++++++++++++++++++--------
 drivers/net/ipa/ipa_main.c     |  1 +
 5 files changed, 109 insertions(+), 42 deletions(-)
Signature · 1 line
2.20.1