Fixup return value for nvme_submit_sync_cmd()
Status from this message: applied to nvme-5.12.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest4 patches 13 repliesApplied
- v36 patches 12 repliesSuperseded
- v25 patches 7 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 2 patches | 3 replies | Superseded |
Changes to v3 from the cover letter
- Dropped patch to change the status code for aborted commands
- Dropped patch to set -ETIMEDOUT on timed out commands
- Include reviews from Chao Leng
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | nvme: simplify error logic in nvme_validate_ns()drivers/ | +4 | 4 replies | |
| 2/4 | nvme: add NVME_REQ_CANCELLED flag in nvme_cancel_request()drivers/ | +1 | 1 reply | |
| 3/4 | nvme-fc: set NVME_REQ_CANCELLED in nvme_fc_terminate_exchange()drivers/ | +1 | 2 replies | |
| 4/4 | nvme-fc: return NVME_SC_HOST_ABORTED_CMD when a command has been aborteddrivers/ | +1 | 4 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Daniel Wagner | Keith Busch | Chao Leng | Sagi Grimberg | James Smart |
|---|---|---|---|---|---|
| 1/4 | R-b | R-b | R-b | ||
| 2/4 | R-b | R-b | R-b | R-b | |
| 3/4 | R-b | R-b | R-b | R-b | |
| 4/4 | R-b | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCHv4 0/4] Fixup return value for nvme_submit_sync_cmd()
Hi all,
here are some small patches for fixing up the return value of nvme_submit_sync_cmd().
As Keith correctly noted, nvme_submit_sync_cmd() should be returning an error if the command could not be performed; however, currently only pci does that.
So we need to fix up nvme_cancel_request() to return an -EINTR on any pending sync commands during reset.
And modify nvme-fc to return the same nvme status after timing out or cancelling requests.
As usual, comments and reviews are welcome.
Changes to v3:
- Dropped patch to change the status code for aborted commands
- Dropped patch to set -ETIMEDOUT on timed out commands
- Include reviews from Chao Leng
Changes to v2:
- Include reviews from Sagi
- Simplify error logic from nvme_validate_ns()
Changes to v1:
- Include reviews from Daniel
- Include changes for nvme-fc to return the same status as the other transports
Hannes Reinecke (4):
nvme: simplify error logic in nvme_validate_ns()
nvme: add NVME_REQ_CANCELLED flag in nvme_cancel_request()
nvme-fc: set NVME_REQ_CANCELLED in nvme_fc_terminate_exchange()
nvme-fc: return NVME_SC_HOST_ABORTED_CMD when a command has been
aborted
drivers/nvme/host/core.c | 9 +++++---- drivers/nvme/host/fc.c | 3 ++- 2 files changed, 7 insertions(+), 5 deletions(-)
Signature · 7 lines
2.29.2 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme