Skip to content

hw/sd: Support block read/write in SPI mode

Bin Meng qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest9 patches 9 repliesIn review

Changes in v4 from the cover letter

- Keep the card state to SSI_SD_CMD instead of SSI_SD_RESPONSE after receiving the STOP_TRAN token per the spec
- new patch: fix STOP_TRANSMISSION (CMD12) response
- new patch: handle the rest commands with R1b response type

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9hw/sd: ssi-sd: Support multiple block readhw/sd/ssi-sd.c+33 -90 replies
2/9hw/sd: sd: Remove duplicated codes in single/multiple block read/writehw/sd/sd.c+0 -470 replies
3/9hw/sd: sd: Allow single/multiple block write for SPI modehw/sd/sd.c+0 -30 replies
4/9hw/sd: Introduce receive_ready() callbackhw/sd/core.c hw/sd/sd.c include/hw/sd/sd.h+21 -00 replies
5/9hw/sd: ssi-sd: Support single block writehw/sd/ssi-sd.c+40 -40 replies
6/9hw/sd: ssi-sd: Support multiple block writehw/sd/ssi-sd.c+31 -20 replies
7/9hw/sd: ssi-sd: Fix SEND_IF_COND (CMD8) responsehw/sd/ssi-sd.c+3 -30 replies
8/9hw/sd: ssi-sd: Fix STOP_TRANSMISSION (CMD12) responsehw/sd/ssi-sd.c+5 -40 replies
9/9hw/sd: ssi-sd: Handle the rest commands with R1b response typehw/sd/ssi-sd.c+6 -04 replies

Reviews trailers per patch

8 of 9 patches have a Reviewed-by or Acked-by.

PatchAlistair FrancisPhilippe Mathieu-Daudé
1/9A-b T-b
2/9A-b T-b
3/9A-b T-b
4/9A-b R-b T-b
5/9A-b T-b
6/9A-b T-b
7/9R-b
8/9
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/9] hw/sd: Support block read/write in SPI mode

From: Bin Meng <[email protected]>

This includes the previously v3 series [1], and one single patch [2].

Compared to v3, this fixed the following issue in patch [v3,6/6]:
- Keep the card state to SSI_SD_CMD instead of SSI_SD_RESPONSE after receiving the STOP_TRAN token per the spec

All software tested so far (U-Boot/Linux/VxWorks) do work without the fix, but it is better to comform with the spec.

In addition to [2], one more issue was exposed when testing with VxWorks driver related to STOP_TRANSMISSION (CMD12) response.

[1] http://patchwork.ozlabs.org/project/qemu-devel/list/?series=226136
[2] http://patchwork.ozlabs.org/project/qemu-devel/patch/[email protected]/

Changes in v4:
- Keep the card state to SSI_SD_CMD instead of SSI_SD_RESPONSE after receiving the STOP_TRAN token per the spec
- new patch: fix STOP_TRANSMISSION (CMD12) response
- new patch: handle the rest commands with R1b response type

Bin Meng (9):
hw/sd: ssi-sd: Support multiple block read
hw/sd: sd: Remove duplicated codes in single/multiple block read/write hw/sd: sd: Allow single/multiple block write for SPI mode hw/sd: Introduce receive_ready() callback
hw/sd: ssi-sd: Support single block write
hw/sd: ssi-sd: Support multiple block write
hw/sd: ssi-sd: Fix SEND_IF_COND (CMD8) response
hw/sd: ssi-sd: Fix STOP_TRANSMISSION (CMD12) response hw/sd: ssi-sd: Handle the rest commands with R1b response type

 include/hw/sd/sd.h |   2 +
 hw/sd/core.c       |  13 +++++
 hw/sd/sd.c         |  56 ++-----------------
 hw/sd/ssi-sd.c     | 136 ++++++++++++++++++++++++++++++++++++++-------
 4 files changed, 137 insertions(+), 70 deletions(-)
Signature · 1 line
2.25.1