Skip to content

xfsprogs: xfs_logprint misc log decoding issues

Donald Douwsma linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2xfs_logprint: print misc buffers when using -ologprint/log_misc.c logprint/log_print_all.c+4 -172 replies
2/2xfs_logprint: decode superblock updates correctlylogprint/log_misc.c logprint/log_print_all.c+19 -262 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] xfsprogs: xfs_logprint misc log decoding issues

I've been seeing confusing superblock transactions in logprint, this is an attempt to resolve them and make debugging misc buffer updates easier.

Before

$ xfs_logprint -o xfs.image
----------------------------------------------------------------------------
Oper (2): tid: c32589f8  len: 24  clientid: TRANS  flags: none
BUF:  #regs: 2   start blkno: 0 (0x0)  len: 1  bmap size: 1  flags: 0x9000
Oper (3): tid: c32589f8  len: 384  clientid: TRANS  flags: none
SUPER BLOCK Buffer:
icount: 6360863066640355328  ifree: 262144  fdblks: 0  frext: 0
----------------------------------------------------------------------------

After

$ xfs_logprint -o xfs.image
----------------------------------------------------------------------------
Oper (2): tid: c32589f8  len: 24  clientid: TRANS  flags: none
BUF:  #regs: 2   start blkno: 0 (0x0)  len: 1  bmap size: 1  flags: 0x9000
Oper (3): tid: c32589f8  len: 384  clientid: TRANS  flags: none
SUPER BLOCK Buffer:
icount: 64  ifree: 61  fdblks: 259564  frext: 0
 0 42534658   100000        0      400        0        0        0        0
 8 84a2ced5 974f8da4 8fd4b0b3 9a870a19        0  4000200        0 80000000
10        0 81000000        0 82000000  1000000      100  4000000        0
18    a0000    2a4b4 10000001        0        0        0  408090c 19000010
20        0 40000000        0 3d000000        0 ecf50300        0        0
28 ffffffff ffffffff ffffffff ffffffff        0  2000000        0        0
30        0  1000000 8a020000 8a020000        0        0        0        0
38        0        0        0        0        0        0        0        0
40        0        0        0        0        0        0        0        0
48        0        0        0        0        0        0        0        0
50        0        0        0        0        0        0        0        0
58        0        0        0        0        0        0        0        0

----------------------------------------------------------------------------

Donald Douwsma (2):
xfs_logprint: print misc buffers when using -o
xfs_logprint: decode superblock updates correctly

 logprint/log_misc.c      | 41 ++++++++++++----------------------------
 logprint/log_print_all.c | 25 +++++++++++-------------
 2 files changed, 23 insertions(+), 43 deletions(-)
Signature · 1 line
2.27.0