Skip to content

drivers: net: update tasklet_init callers

Emil Renner Berthing linux-ppp linux-usb lkml netdev 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/9arcnet: use new tasklet APIdrivers/net/arcnet/arcnet.c+3 -40 replies
2/9caif_virtio: use new tasklet APIdrivers/net/caif/caif_virtio.c+3 -50 replies
3/9ifb: use new tasklet APIdrivers/net/ifb.c+3 -40 replies
4/9ppp: use new tasklet APIdrivers/net/ppp/ppp_async.c drivers/net/ppp/ppp_synctty.c+8 -80 replies
5/9net: usb: hso: use new tasklet APIdrivers/net/usb/hso.c+5 -50 replies
6/9net: usb: lan78xx: use new tasklet APIdrivers/net/usb/lan78xx.c+3 -30 replies
7/9net: usb: pegasus: use new tasklet APIdrivers/net/usb/pegasus.c+3 -40 replies
8/9net: usb: r8152: use new tasklet APIdrivers/net/usb/r8152.c+3 -50 replies
9/9net: usb: rtl8150: use new tasklet APIdrivers/net/usb/rtl8150.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] drivers: net: update tasklet_init callers

This updates the remaining callers of tasklet_init() in drivers/net to the new API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")

All changes are done by coccinelle using the following semantic patch. Coccinelle needs a little help parsing drivers/net/arcnet/arcnet.c

@ match @
type T;
T *container;
identifier tasklet;
identifier callback;
@@

	tasklet_init(&container->tasklet, callback, (unsigned long)container);

@ patch1 depends on match @
type match.T;
identifier match.tasklet;
identifier match.callback;
identifier data;
identifier container;
@@
-void callback(unsigned long data)
+void callback(struct tasklet_struct *t)

{
	...
-	T *container = (T *)data;
+	T *container = from_tasklet(container, t, tasklet);
	...
}

@ patch2 depends on match @
type match.T;
identifier match.tasklet;
identifier match.callback;
identifier data;
identifier container;
@@
-void callback(unsigned long data)
+void callback(struct tasklet_struct *t)

{
	...
-	T *container;
+	T *container = from_tasklet(container, t, tasklet);
	...
-	container = (T *)data;
	...
}

@ depends on (patch1 || patch2) @
match.T *container;
identifier match.tasklet;
identifier match.callback;
@@
- tasklet_init(&container->tasklet, callback, (unsigned long)container);
+ tasklet_setup(&container->tasklet, callback);

Emil Renner Berthing (9):
arcnet: use new tasklet API
caif_virtio: use new tasklet API
ifb: use new tasklet API
ppp: use new tasklet API
net: usb: hso: use new tasklet API
net: usb: lan78xx: use new tasklet API
net: usb: pegasus: use new tasklet API
net: usb: r8152: use new tasklet API
net: usb: rtl8150: use new tasklet API

 drivers/net/arcnet/arcnet.c    |  7 +++----
 drivers/net/caif/caif_virtio.c |  8 +++-----
 drivers/net/ifb.c              |  7 +++----
 drivers/net/ppp/ppp_async.c    |  8 ++++----
 drivers/net/ppp/ppp_synctty.c  |  8 ++++----
 drivers/net/usb/hso.c          | 10 +++++-----
 drivers/net/usb/lan78xx.c      |  6 +++---
 drivers/net/usb/pegasus.c      |  7 +++----
 drivers/net/usb/r8152.c        |  8 +++-----
 drivers/net/usb/rtl8150.c      |  6 +++---
 10 files changed, 34 insertions(+), 41 deletions(-)
Signature · 1 line
2.30.0