Skip to content

Add KVM support for bus lock debug exception

Chenyi Qiang kvm lkml oe-kbuild-all 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 7 repliesIn review
  2. v11 patch 1 replyApplied

Changes in v2 from the cover letter

- rename the DR6_INIT to DR6_LOW_ACTIVE suggested by Paolo and split it out as a new commit.
- KVM v1:https://lore.kernel.org/lkml/[email protected]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3KVM: X86: Rename DR6_INIT to DR6_ACTIVE_LOWarch/x86/include/asm/kvm_host.h arch/x86/kvm/emulate.c arch/x86/kvm/svm/nested.c +4 more+36 -247 replies
2/3KVM: X86: Add support for the emulation of DR6_BUS_LOCK bitarch/x86/include/asm/kvm_host.h arch/x86/kvm/x86.c+6 -20 replies
3/3KVM: X86: Expose bus lock debug exception to guestarch/x86/kvm/cpuid.c arch/x86/kvm/vmx/vmx.c arch/x86/kvm/x86.c +1 more+27 -170 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] Add KVM support for bus lock debug exception

A bus lock is acquired either through split locked access to writeback (WB) memory or by using locks to uncacheable (UC) memory. This is typically > 1000 cycles slower than atomic opertaion within a cache line. It also disrupts performance on other cores.

Bus lock debug exception is a sub-feature of bus lock detection. It is an ability to notify the kernel by an #DB trap after the instruction acquires a bus lock when CPL>0. This allows the kernel to enforce user application throttling or mitigatioins.

Expose the bus lock debug exception to guest by the enumeration of CPUID.(EAX=7,ECX=0).ECX[24]. Software in guest can enable these exceptions by setting the DEBUGCTLMSR_BUS_LOCK_DETECT(bit 2) of MSR_IA32_DEBUTCTL.

The bus lock #DB exception can also be intercepted by the VMM and identified through the bit 11 of the exit qualification at VM exit. The bit 11 (DR6_BUS_LOCK) of DR6 register is introduced to indicate a bus lock #DB exception. DR6_BUS_LOCK has formerly always been 1 and delivery of a bus lock #DB clears it. The VMM should emulate the exceptions by clearing the bit 11 of the guest DR6.

Bus lock debug exception kernel patches are available at:
https://lore.kernel.org/lkml/[email protected]

Document for Bus Lock Detection is now available at the latest "Intel Architecture Instruction Set Extensions Programming Reference".

Document Link:
https://software.intel.com/content/www/us/en/develop/download/intel-architecture-instruction-set-extensions-programming-reference.html

---

Changelogs

v1->v2:
- rename the DR6_INIT to DR6_LOW_ACTIVE suggested by Paolo and split it out as a new commit.
- KVM v1:https://lore.kernel.org/lkml/[email protected]

Chenyi Qiang (3):
KVM: X86: Rename DR6_INIT to DR6_ACTIVE_LOW
KVM: X86: Add support for the emulation of DR6_BUS_LOCK bit
KVM: X86: Expose bus lock debug exception to guest

 arch/x86/include/asm/kvm_host.h | 14 +++++++--
 arch/x86/kvm/cpuid.c            |  3 +-
 arch/x86/kvm/emulate.c          |  2 +-
 arch/x86/kvm/svm/nested.c       |  2 +-
 arch/x86/kvm/svm/svm.c          |  6 ++--
 arch/x86/kvm/vmx/nested.c       |  4 +--
 arch/x86/kvm/vmx/vmx.c          | 27 ++++++++++++++---
 arch/x86/kvm/x86.c              | 52 +++++++++++++++------------------
 arch/x86/kvm/x86.h              |  2 ++
 9 files changed, 69 insertions(+), 43 deletions(-)
Signature · 1 line
2.17.1