Skip to content

perf/x86: Some minor changes to support guest Arch LBR

Like Xu lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 posting 3/310 patches 6 repliesIn review
  2. v5 Latest5 patches 2 repliesIn review
  3. v4 posting 2/35 patches 11 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v4 posting 1/311 patches3 repliesSuperseded
v39 patches18 repliesSuperseded
v24 patches9 repliesSuperseded

Changes in v5 from the cover letter

- Add "Tested-by: Kan Liang"
- Make the commit message simpler
- Make check_msr() to ignore msr==0
- Use kmem_cache_alloc_node() [Namhyung]

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5perf/x86/intel: Fix the comment about guest LBR support on KVMarch/x86/events/intel/core.c+1 -20 replies
2/5perf/x86/lbr: Simplify the exposure check for the LBR_INFO registersarch/x86/events/intel/lbr.c+1 -30 replies
3/5perf/x86: Skip checking MSR for MSR 0x000arch/x86/events/intel/core.c+2 -20 replies
4/5perf/x86/lbr: Move cpuc->lbr_xsave allocation out of sleeping regionarch/x86/events/core.c arch/x86/events/intel/bts.c arch/x86/events/intel/lbr.c +1 more+30 -110 replies
5/5perf/x86: Move ARCH_LBR_CTL_MASK definition to include/asm/msr-index.harch/x86/events/intel/lbr.c arch/x86/include/asm/msr-index.h+1 -20 replies

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchKan LiangAndi Kleen
1/5R-b R-b
2/5R-b R-b
3/5R-b
4/5T-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/5] perf/x86: Some minor changes to support guest Arch LBR

Hi Peter,

Please help review these minor perf/x86 changes in this patch set, and we need some of them to support Guest Architectural LBR in KVM.

This version keeps reserve_lbr_buffers() as is because the LBR xsave buffer is a per-CPU buffer, not a per-event buffer. We only need to allocate the buffer once when initializing the first event.

If you are interested in the KVM emulation, please check
https://lore.kernel.org/kvm/[email protected]/

Please check more details in each commit and feel free to comment.

Previous:
https://lore.kernel.org/lkml/[email protected]/

v4->v5 Changelog:
- Add "Tested-by: Kan Liang"
- Make the commit message simpler
- Make check_msr() to ignore msr==0
- Use kmem_cache_alloc_node() [Namhyung]

Like Xu (5):
perf/x86/intel: Fix the comment about guest LBR support on KVM perf/x86/lbr: Simplify the exposure check for the LBR_INFO registers perf/x86: Skip checking MSR for MSR 0x000
perf/x86/lbr: Move cpuc->lbr_xsave allocation out of sleeping region perf/x86: Move ARCH_LBR_CTL_MASK definition to include/asm/msr-index.h

 arch/x86/events/core.c           |  8 +++++---
 arch/x86/events/intel/bts.c      |  2 +-
 arch/x86/events/intel/core.c     |  7 +++----
 arch/x86/events/intel/lbr.c      | 29 ++++++++++++++++++-----------
 arch/x86/events/perf_event.h     |  8 +++++++-
 arch/x86/include/asm/msr-index.h |  1 +
 6 files changed, 35 insertions(+), 20 deletions(-)
Signature · 1 line
2.29.2