5.10.14-rc1 review
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest57 patches 11 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/57 | net: dsa: microchip: Adjust reset release timing to match reference reset circuitdrivers/ | +1 | 0 replies | |
| 2/57 | net: stmmac: dwmac-intel-plat: remove config data on errordrivers/ | +2 | 0 replies | |
| 3/57 | net: fec: put child node on error pathdrivers/ | +2 | 0 replies | |
| 4/57 | net: octeontx2: Make sure the buffer is 128 byte aligneddrivers/ | +2 | 2 replies | |
| 5/57 | stmmac: intel: Configure EHL PSE0 GbE and PSE1 GbE to 32 bits DMA addressingdrivers/ | +2 | 0 replies | |
| 6/57 | mlxsw: spectrum_span: Do not overwrite policer configurationdrivers/ drivers/ | +7 | 0 replies | |
| 7/57 | net: dsa: bcm_sf2: put device node before returndrivers/ | +6 | 0 replies | |
| 8/57 | net: switchdev: dont set port_obj_info->handled true when -EOPNOTSUPPnet/ | +13 | 0 replies | |
| 9/57 | ibmvnic: Ensure that CRQ entry read are correctly ordereddrivers/ | +6 | 0 replies | |
| 10/57 | iommu/io-pgtable-arm: Support coherency for Mali LPAEdrivers/ | +10 | 0 replies | |
| 11/57 | drm/panfrost: Support cache-coherent integrationsdrivers/ drivers/ drivers/ +1 more | +6 | 0 replies | |
| 12/57 | arm64: dts: meson: Describe G12b GPU as coherentarch/ | +4 | 0 replies | |
| 13/57 | arm64: Fix kernel address detection of __is_lm_address()arch/ | +4 | 0 replies | |
| 14/57 | arm64: Do not pass tagged addresses to __is_lm_address()arch/ arch/ | +2 | 0 replies | |
| 15/57 | Revert "x86/setup: dont remove E820_TYPE_RAM for pfn 0"arch/ | +11 | 0 replies | |
| 16/57 | ARM: 9025/1: Kconfig: CPU_BIG_ENDIAN depends on !LD_IS_LLDarch/ | +1 | 0 replies | |
| 17/57 | iommu/vt-d: Do not use flush-queue when caching-mode is ondrivers/ | +5 | 0 replies | |
| 18/57 | phy: cpcap-usb: Fix warning for missing regulator_disabledrivers/ | +13 | 0 replies | |
| 19/57 | tools/power/x86/intel-speed-select: Set scaling_max_freq to base_frequencytools/ | +21 | 0 replies | |
| 20/57 | tools/power/x86/intel-speed-select: Set higher of cpuinfo_max_freq or base_frequencytools/ | +11 | 0 replies | |
| 21/57 | platform/x86: touchscreen_dmi: Add swap-x-y quirk for Goodix touchscreen on Estar Beauty HD tabletdrivers/ | +18 | 0 replies | |
| 22/57 | platform/x86: intel-vbtn: Support for tablet mode on Dell Inspiron 7352drivers/ | +6 | 0 replies | |
| 23/57 | habanalabs: fix dma_addr passed to dma_mmap_coherentdrivers/ drivers/ | +4 | 0 replies | |
| 24/57 | locking/lockdep: Avoid noinstr warning for DEBUG_LOCKDEPkernel/ | +6 | 0 replies | |
| 25/57 | x86: __always_inline __{rd,wr}msr()arch/ | +2 | 0 replies | |
| 26/57 | scsi: scsi_transport_srp: Dont block target in failfast statedrivers/ | +8 | 0 replies | |
| 27/57 | scsi: libfc: Avoid invoking response handler twice if ep is already completeddrivers/ | +14 | 0 replies | |
| 28/57 | scsi: fnic: Fix memleak in vnic_dev_init_devcmd2drivers/ | +5 | 0 replies | |
| 29/57 | ASoC: SOF: Intel: hda: Resume codec to do jack detectionsound/ | +1 | 0 replies | |
| 30/57 | ALSA: hda: Add AlderLake-P PCI ID and HDMI codec vidsound/ sound/ | +4 | 0 replies | |
| 31/57 | objtool: Dont add empty symbols to the rbtreetools/ | +7 | 0 replies | |
| 32/57 | mac80211: fix incorrect strlen of .write in debugfsnet/ | +20 | 0 replies | |
| 33/57 | mac80211: fix fast-rx encryption checknet/ | +2 | 0 replies | |
| 34/57 | mac80211: fix encryption key selection for 802.3 xmitnet/ | +15 | 0 replies | |
| 35/57 | scsi: ibmvfc: Set default timeout to avoid crash during migrationdrivers/ | +3 | 0 replies | |
| 36/57 | ALSA: hda: Add Cometlake-R PCI IDsound/ | +3 | 0 replies | |
| 37/57 | i2c: tegra: Create i2c_writesl_vi() to use with VI I2C for filling TX FIFOdrivers/ | +21 | 0 replies | |
| 38/57 | udf: fix the problem that the disc content is not displayedfs/ | +4 | 0 replies | |
| 39/57 | nvme: check the PRINFO bit before deciding the host buffer lengthdrivers/ | +15 | 0 replies | |
| 40/57 | nvme-rdma: avoid request double completion for concurrent nvme_rdma_timeoutdrivers/ | +11 | 0 replies | |
| 41/57 | nvme-tcp: avoid request double completion for concurrent nvme_tcp_timeoutdrivers/ | +10 | 0 replies | |
| 42/57 | nvme-pci: allow use of cmb on v1.4 controllersdrivers/ include/ | +20 | 0 replies | |
| 43/57 | nvmet: set right status on error in id-ns handlerdrivers/ | +6 | 0 replies | |
| 44/57 | platform/x86: thinkpad_acpi: Add P53/73 firmware to fan_quirk_table for dual fan controldrivers/ | +1 | 0 replies | |
| 45/57 | selftests/powerpc: Only test lwm/stmw on big endiantools/ | +4 | 0 replies | |
| 46/57 | drm/amd/display: Update dram_clock_change_latency for DCN2.1drivers/ | +1 | 0 replies | |
| 47/57 | drm/amd/display: Allow PSTATE chnage when no displays are enableddrivers/ | +4 | 0 replies | |
| 48/57 | drm/amd/display: Change function decide_dp_link_settings to avoid infinite loopingdrivers/ | +3 | 0 replies | |
| 49/57 | drm/amd/display: Use hardware sequencer functions for PG controldrivers/ drivers/ | +21 | 0 replies | |
| 50/57 | drm/amd/display: Fixed corruptions on HPDRX link loss restoredrivers/ | +2 | 0 replies | |
| 51/57 | habanalabs: zero pci counters packet before submit to FWdrivers/ | +5 | 0 replies | |
| 52/57 | habanalabs: fix backward compatibility of idle checkdrivers/ | +2 | 0 replies | |
| 53/57 | habanalabs: disable FW events on device removaldrivers/ | +9 | 0 replies | |
| 54/57 | objtool: Dont fail the kernel build on fatal errorstools/ | +5 | 0 replies | |
| 55/57 | x86/cpu: Add another Alder Lake CPU to the Intel familyarch/ | +1 | 0 replies | |
| 56/57 | kthread: Extract KTHREAD_IS_PER_CPUinclude/ kernel/ kernel/ | +30 | 0 replies | |
| 57/57 | workqueue: Restrict affinity change to rescuerkernel/ | +3 | 0 replies |
Reviews trailers per patch
28 of 57 patches have a Reviewed-by or Acked-by.
| Patch | Israel Rukshin | Tony Cheng | Aurabindo Pillai | Subbaraya Sundeep | Petr Machata | Valentin Schneider | Miroslav Benes | Nick Desaulniers | Kamalesh Babulal | Ard Biesheuvel | Ranjani Sridharan | Pierre-Louis Bossart | Guennadi Liakhovetski | Dmitry Osipenko | Thierry Reding | Catalin Marinas | Mark Rutland | Randy Dunlap | Nathan Chancellor | Kai Vehmanen | Daniel Wheeler | Jun Lei | Anson Jacob | Karan Tilak Kumar | Bart Van Assche | Peter Zijlstra (Intel) | Eric Yang | Oded Gabbay | Aric Cyr | Libor Pechacek | Lu Baolu | Florian Fainelli | Paul Barker | Andrew Lunn | Neil Armstrong | Steven Price | Will Deacon | Sagi Grimberg | Pavel Machek (CIP) | Igor Matheus Andrade Torrente | Linux Kernel Functional Testing | Guenter Roeck | Jean-Denis Girard | Jon Hunter |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Series | T-b | T-b | T-b | T-b | T-b | T-b | ||||||||||||||||||||||||||||||||||||||
| 1/57 | R-b | R-b | R-b | |||||||||||||||||||||||||||||||||||||||||
| 2/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 3/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 4/57 | T-b | |||||||||||||||||||||||||||||||||||||||||||
| 5/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 6/57 | R-b | |||||||||||||||||||||||||||||||||||||||||||
| 7/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 8/57 | R-b | |||||||||||||||||||||||||||||||||||||||||||
| 9/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 10/57 | T-b | R-b | A-b | |||||||||||||||||||||||||||||||||||||||||
| 11/57 | T-b | R-b | ||||||||||||||||||||||||||||||||||||||||||
| 12/57 | T-b R-b | |||||||||||||||||||||||||||||||||||||||||||
| 13/57 | R-b | A-b | ||||||||||||||||||||||||||||||||||||||||||
| 14/57 | A-b | |||||||||||||||||||||||||||||||||||||||||||
| 15/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 16/57 | T-b R-b | |||||||||||||||||||||||||||||||||||||||||||
| 17/57 | A-b | |||||||||||||||||||||||||||||||||||||||||||
| 18/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 19/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 20/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 21/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 22/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 23/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 24/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 25/57 | A-b | |||||||||||||||||||||||||||||||||||||||||||
| 26/57 | R-b | |||||||||||||||||||||||||||||||||||||||||||
| 27/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 28/57 | A-b | |||||||||||||||||||||||||||||||||||||||||||
| 29/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 30/57 | R-b | R-b | R-b | |||||||||||||||||||||||||||||||||||||||||
| 31/57 | A-b | |||||||||||||||||||||||||||||||||||||||||||
| 32/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 33/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 34/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 35/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 36/57 | R-b | |||||||||||||||||||||||||||||||||||||||||||
| 37/57 | R-b | A-b | ||||||||||||||||||||||||||||||||||||||||||
| 38/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 39/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 40/57 | T-b R-b | |||||||||||||||||||||||||||||||||||||||||||
| 41/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 42/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 43/57 | R-b | |||||||||||||||||||||||||||||||||||||||||||
| 44/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 45/57 | T-b | |||||||||||||||||||||||||||||||||||||||||||
| 46/57 | R-b | A-b | ||||||||||||||||||||||||||||||||||||||||||
| 47/57 | T-b | R-b | A-b | |||||||||||||||||||||||||||||||||||||||||
| 48/57 | T-b | R-b | A-b | |||||||||||||||||||||||||||||||||||||||||
| 49/57 | T-b | A-b | R-b | |||||||||||||||||||||||||||||||||||||||||
| 50/57 | T-b | A-b | R-b | |||||||||||||||||||||||||||||||||||||||||
| 51/57 | R-b | |||||||||||||||||||||||||||||||||||||||||||
| 52/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 53/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 54/57 | R-b | R-b | R-b | |||||||||||||||||||||||||||||||||||||||||
| 55/57 | ||||||||||||||||||||||||||||||||||||||||||||
| 56/57 | R-b T-b | |||||||||||||||||||||||||||||||||||||||||||
| 57/57 | R-b T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 44 reviewers.
Cover letter [PATCH 5.10 00/57] 5.10.14-rc1 review
This is the start of the stable review cycle for the 5.10.14 release. There are 57 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun, 07 Feb 2021 14:06:42 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.14-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 5.10.14-rc1
Peter Zijlstra <[email protected]>
workqueue: Restrict affinity change to rescuer
Peter Zijlstra <[email protected]>
kthread: Extract KTHREAD_IS_PER_CPU
Gayatri Kammela <[email protected]>
x86/cpu: Add another Alder Lake CPU to the Intel family
Josh Poimboeuf <[email protected]>
objtool: Don't fail the kernel build on fatal errors
Oded Gabbay <[email protected]>
habanalabs: disable FW events on device removal
Oded Gabbay <[email protected]>
habanalabs: fix backward compatibility of idle check
Ofir Bitton <[email protected]>
habanalabs: zero pci counters packet before submit to FW
Vladimir Stempen <[email protected]>
drm/amd/display: Fixed corruptions on HPDRX link loss restore
Nicholas Kazlauskas <[email protected]>
drm/amd/display: Use hardware sequencer functions for PG control
Bing Guo <[email protected]>
drm/amd/display: Change function decide_dp_link_settings to avoid infinite looping
Aric Cyr <[email protected]>
drm/amd/display: Allow PSTATE chnage when no displays are enabled
Jake Wang <[email protected]>
drm/amd/display: Update dram_clock_change_latency for DCN2.1
Michael Ellerman <[email protected]>
selftests/powerpc: Only test lwm/stmw on big endian
Jeannie Stevenson <[email protected]>
platform/x86: thinkpad_acpi: Add P53/73 firmware to fan_quirk_table for dual fan control
Chaitanya Kulkarni <[email protected]>
nvmet: set right status on error in id-ns handler
Klaus Jensen <[email protected]>
nvme-pci: allow use of cmb on v1.4 controllers
Chao Leng <[email protected]>
nvme-tcp: avoid request double completion for concurrent nvme_tcp_timeout
Chao Leng <[email protected]>
nvme-rdma: avoid request double completion for concurrent nvme_rdma_timeout
Revanth Rajashekar <[email protected]>
nvme: check the PRINFO bit before deciding the host buffer length
lianzhi chang <[email protected]>
udf: fix the problem that the disc content is not displayed
Sowjanya Komatineni <[email protected]>
i2c: tegra: Create i2c_writesl_vi() to use with VI I2C for filling TX FIFO
Kai-Chuan Hsieh <[email protected]>
ALSA: hda: Add Cometlake-R PCI ID
Brian King <[email protected]>
scsi: ibmvfc: Set default timeout to avoid crash during migration
Felix Fietkau <[email protected]>
mac80211: fix encryption key selection for 802.3 xmit
Felix Fietkau <[email protected]>
mac80211: fix fast-rx encryption check
Shayne Chen <[email protected]>
mac80211: fix incorrect strlen of .write in debugfs
Josh Poimboeuf <[email protected]>
objtool: Don't add empty symbols to the rbtree
Kai Vehmanen <[email protected]>
ALSA: hda: Add AlderLake-P PCI ID and HDMI codec vid
Kai-Heng Feng <[email protected]>
ASoC: SOF: Intel: hda: Resume codec to do jack detection
Dinghao Liu <[email protected]>
scsi: fnic: Fix memleak in vnic_dev_init_devcmd2
Javed Hasan <[email protected]>
scsi: libfc: Avoid invoking response handler twice if ep is already completed
Martin Wilck <[email protected]>
scsi: scsi_transport_srp: Don't block target in failfast state
Peter Zijlstra <[email protected]>
x86: __always_inline __{rd,wr}msr()Peter Zijlstra <[email protected]>
locking/lockdep: Avoid noinstr warning for DEBUG_LOCKDEP
Oded Gabbay <[email protected]>
habanalabs: fix dma_addr passed to dma_mmap_coherent
Arnold Gozum <[email protected]>
platform/x86: intel-vbtn: Support for tablet mode on Dell Inspiron 7352
Hans de Goede <[email protected]>
platform/x86: touchscreen_dmi: Add swap-x-y quirk for Goodix touchscreen on Estar Beauty HD tablet
Srinivas Pandruvada <[email protected]>
tools/power/x86/intel-speed-select: Set higher of cpuinfo_max_freq or base_frequency
Srinivas Pandruvada <[email protected]>
tools/power/x86/intel-speed-select: Set scaling_max_freq to base_frequency
Tony Lindgren <[email protected]>
phy: cpcap-usb: Fix warning for missing regulator_disable
Nadav Amit <[email protected]>
iommu/vt-d: Do not use flush-queue when caching-mode is on
Nick Desaulniers <[email protected]>
ARM: 9025/1: Kconfig: CPU_BIG_ENDIAN depends on !LD_IS_LLD
Mike Rapoport <[email protected]>
Revert "x86/setup: don't remove E820_TYPE_RAM for pfn 0"
Catalin Marinas <[email protected]>
arm64: Do not pass tagged addresses to __is_lm_address()
Vincenzo Frascino <[email protected]>
arm64: Fix kernel address detection of __is_lm_address()
Robin Murphy <[email protected]>
arm64: dts: meson: Describe G12b GPU as coherent
Robin Murphy <[email protected]>
drm/panfrost: Support cache-coherent integrations
Robin Murphy <[email protected]>
iommu/io-pgtable-arm: Support coherency for Mali LPAE
Lijun Pan <[email protected]>
ibmvnic: Ensure that CRQ entry read are correctly ordered
Rasmus Villemoes <[email protected]>
net: switchdev: don't set port_obj_info->handled true when -EOPNOTSUPP
Pan Bian <[email protected]>
net: dsa: bcm_sf2: put device node before return
Ido Schimmel <[email protected]>
mlxsw: spectrum_span: Do not overwrite policer configuration
Voon Weifeng <[email protected]>
stmmac: intel: Configure EHL PSE0 GbE and PSE1 GbE to 32 bits DMA addressing
Kevin Hao <[email protected]>
net: octeontx2: Make sure the buffer is 128 byte aligned
Pan Bian <[email protected]>
net: fec: put child node on error path
Pan Bian <[email protected]>
net: stmmac: dwmac-intel-plat: remove config data on error
Marek Vasut <[email protected]>
net: dsa: microchip: Adjust reset release timing to match reference reset circuit
-------------
Diffstat:
Makefile | 4 +- arch/arm/mm/Kconfig | 1 + arch/arm64/boot/dts/amlogic/meson-g12b.dtsi | 4 ++ arch/arm64/include/asm/memory.h | 10 ++--- arch/arm64/mm/physaddr.c | 2 +- arch/x86/include/asm/intel-family.h | 1 + arch/x86/include/asm/msr.h | 4 +- arch/x86/kernel/setup.c | 20 +++++----- .../amd/display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c | 6 ++- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 7 +++- .../drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 18 +++++++-- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 9 ++++- .../gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 2 +- drivers/gpu/drm/panfrost/panfrost_device.h | 1 + drivers/gpu/drm/panfrost/panfrost_drv.c | 2 + drivers/gpu/drm/panfrost/panfrost_gem.c | 2 + drivers/gpu/drm/panfrost/panfrost_mmu.c | 1 + drivers/i2c/busses/i2c-tegra.c | 22 ++++++++++- drivers/iommu/intel/iommu.c | 5 +++ drivers/iommu/io-pgtable-arm.c | 11 +++++- drivers/misc/habanalabs/common/device.c | 9 +++++ drivers/misc/habanalabs/common/firmware_if.c | 5 +++ drivers/misc/habanalabs/common/habanalabs_ioctl.c | 2 + drivers/misc/habanalabs/gaudi/gaudi.c | 3 +- drivers/misc/habanalabs/goya/goya.c | 3 +- drivers/net/dsa/bcm_sf2.c | 8 +++- drivers/net/dsa/microchip/ksz_common.c | 2 +- drivers/net/ethernet/freescale/fec_main.c | 3 +- drivers/net/ethernet/ibm/ibmvnic.c | 6 +++ .../ethernet/marvell/octeontx2/nic/otx2_common.c | 3 +- .../net/ethernet/mellanox/mlxsw/spectrum_span.c | 6 +++ .../net/ethernet/mellanox/mlxsw/spectrum_span.h | 1 + .../net/ethernet/stmicro/stmmac/dwmac-intel-plat.c | 4 +- drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 2 + drivers/nvme/host/core.c | 17 ++++++++- drivers/nvme/host/pci.c | 14 +++++++ drivers/nvme/host/rdma.c | 15 ++++++-- drivers/nvme/host/tcp.c | 14 +++++-- drivers/nvme/target/admin-cmd.c | 8 +++- drivers/phy/motorola/phy-cpcap-usb.c | 19 +++++++--- drivers/platform/x86/intel-vbtn.c | 6 +++ drivers/platform/x86/thinkpad_acpi.c | 1 + drivers/platform/x86/touchscreen_dmi.c | 18 +++++++++ drivers/scsi/fnic/vnic_dev.c | 8 ++-- drivers/scsi/ibmvscsi/ibmvfc.c | 4 +- drivers/scsi/libfc/fc_exch.c | 16 +++++++- drivers/scsi/scsi_transport_srp.c | 9 ++++- fs/udf/super.c | 7 ++-- include/linux/kthread.h | 3 ++ include/linux/nvme.h | 6 +++ kernel/kthread.c | 27 ++++++++++++- kernel/locking/lockdep.c | 7 +++- kernel/smpboot.c | 1 + kernel/workqueue.c | 9 ++--- net/mac80211/debugfs.c | 44 ++++++++++------------ net/mac80211/rx.c | 2 + net/mac80211/tx.c | 27 +++++++------ net/switchdev/switchdev.c | 23 ++++++----- sound/pci/hda/hda_intel.c | 6 +++ sound/pci/hda/patch_hdmi.c | 1 + sound/soc/sof/intel/hda-codec.c | 3 +- tools/objtool/check.c | 14 +++---- tools/objtool/elf.c | 7 ++++ tools/power/x86/intel-speed-select/isst-config.c | 32 ++++++++++++++++ .../powerpc/alignment/alignment_handler.c | 5 ++- 65 files changed, 427 insertions(+), 135 deletions(-)