Skip to content

close udev startup race condition for several devices

Jeffle Xu stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 1 replyIn review
  2. v13 patches 7 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6Revert "zram: close udev startup race condition as default groups"drivers/block/zram/zram_drv.c+20 -60 replies
2/6block: genhd: add 'groups' argument to device_add_diskarch/um/drivers/ubd_kern.c block/genhd.c drivers/block/floppy.c +25 more+43 -330 replies
3/6nvme: register ns_id attributes as default sysfs groupsdrivers/nvme/host/core.c drivers/nvme/host/lightnvm.c drivers/nvme/host/multipath.c +1 more+59 -920 replies
4/6aoe: register default groups with device_add_disk()drivers/block/aoe/aoe.h drivers/block/aoe/aoeblk.c drivers/block/aoe/aoedev.c+7 -160 replies
5/6zram: register default groups with device_add_disk()drivers/block/zram/zram_drv.c+7 -210 replies
6/6virtio-blk: modernize sysfs attribute creationdrivers/block/virtio_blk.c+39 -290 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigMichael S. TsirkinBart Van AsscheKeith BuschEd L. Cachin
1/6
2/6R-b R-b
3/6R-b
4/6R-b R-b A-b
5/6R-b R-b
6/6R-b A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [PATCH v2 4.19 0/6] close udev startup race condition for several devices

Please refer to v1 ([1]) and background ([2]) for more details.

As Sasha suggested in [3], revert commit 9e07f4e24379 ("zram: close udev startup race condition as default groups") first, and then apply the original patch set.

- patch 5: fix the issue of zram that the original commit (9e07f4e24379) wants to fix
- patch 6: fix the issue of virtio-blk ([2])
- patch 3/4: I have not occured with these two issues in real world. Put here just for completeness.

This patch set is for 4.19, though it shall be backported to 4.4/4.9/4.14/4.19. Send this patch set out first for more feedbacks.

I have only tested the issue of virtio-blk though.

[1] https://lore.kernel.org/stable/[email protected]/
[2] https://lore.kernel.org/stable/[email protected]/
[3] https://lore.kernel.org/stable/20210207224612.GY4035784@sasha-vm/

Hannes Reinecke (5):
block: genhd: add 'groups' argument to device_add_disk
nvme: register ns_id attributes as default sysfs groups
aoe: register default groups with device_add_disk()
zram: register default groups with device_add_disk()
virtio-blk: modernize sysfs attribute creation

Jeffle Xu (1):
Revert "zram: close udev startup race condition as default groups"

 arch/um/drivers/ubd_kern.c          |   2 +-
 block/genhd.c                       |  19 +++--
 drivers/block/aoe/aoe.h             |   1 -
 drivers/block/aoe/aoeblk.c          |  21 ++----
 drivers/block/aoe/aoedev.c          |   1 -
 drivers/block/floppy.c              |   2 +-
 drivers/block/mtip32xx/mtip32xx.c   |   2 +-
 drivers/block/ps3disk.c             |   2 +-
 drivers/block/ps3vram.c             |   2 +-
 drivers/block/rsxx/dev.c            |   2 +-
 drivers/block/skd_main.c            |   2 +-
 drivers/block/sunvdc.c              |   2 +-
 drivers/block/virtio_blk.c          |  68 ++++++++++--------
 drivers/block/xen-blkfront.c        |   2 +-
 drivers/block/zram/zram_drv.c       |   4 +-
 drivers/ide/ide-cd.c                |   2 +-
 drivers/ide/ide-gd.c                |   2 +-
 drivers/memstick/core/ms_block.c    |   2 +-
 drivers/memstick/core/mspro_block.c |   2 +-
 drivers/mmc/core/block.c            |   2 +-
 drivers/mtd/mtd_blkdevs.c           |   2 +-
 drivers/nvdimm/blk.c                |   2 +-
 drivers/nvdimm/btt.c                |   2 +-
 drivers/nvdimm/pmem.c               |   2 +-
 drivers/nvme/host/core.c            |  21 +++---
 drivers/nvme/host/lightnvm.c        | 105 ++++++++++++----------------
 drivers/nvme/host/multipath.c       |  15 ++--
 drivers/nvme/host/nvme.h            |  10 +--
 drivers/s390/block/dasd_genhd.c     |   2 +-
 drivers/s390/block/dcssblk.c        |   2 +-
 drivers/s390/block/scm_blk.c        |   2 +-
 drivers/scsi/sd.c                   |   2 +-
 drivers/scsi/sr.c                   |   2 +-
 include/linux/genhd.h               |   5 +-
 34 files changed, 147 insertions(+), 169 deletions(-)
Signature · 1 line
2.27.0