Skip to content

occ: fsi and hwmon: Fixes for polling un-initialized OCC

Eddie James linux-hwmon lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4fsi: occ: Don't accept response from un-initialized OCCdrivers/fsi/fsi-occ.c+1 -01 reply
2/4fsi: occ: Log error for checksum failuredrivers/fsi/fsi-occ.c+7 -31 reply
3/4hwmon: (occ) Start sequence number at onedrivers/hwmon/occ/common.c+2 -01 reply
4/4hwmon: (occ) Print response status in first poll error messagedrivers/hwmon/occ/common.c+3 -21 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchGuenter RoeckJoel Stanley
1/4R-b
2/4R-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] occ: fsi and hwmon: Fixes for polling un-initialized OCC

In the event that the OCC is not initialized when the driver sends a poll command, the driver may receive an invalid response. This isn't an error condition unless there is no valid response before the timeout expires. So change the starting sequence number and check for the un-initialized OCC state before returning the response in order to detect this condition and continue waiting if necessary.

Eddie James (4):
fsi: occ: Don't accept response from un-initialized OCC
fsi: occ: Log error for checksum failure
hwmon: (occ) Start sequence number at one
hwmon: (occ) Print response status in first poll error message

 drivers/fsi/fsi-occ.c      | 11 ++++++++---
 drivers/hwmon/occ/common.c |  7 +++++--
 2 files changed, 13 insertions(+), 5 deletions(-)
Signature · 1 line
2.27.0