Skip to content

add support for never printing hashed addresses

Timur Tabi linux-mm lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 20 repliesIn review
  2. v33 patches 11 repliesSuperseded
  3. v13 patches 19 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3lib: use KSTM_MODULE_GLOBALS macro in kselftest driverslib/test_bitmap.c lib/test_printf.c+3 -40 replies
2/3kselftest: add support for skipped teststools/testing/selftests/kselftest_module.h+12 -60 replies
3/3lib/vsprintf: no_hash_pointers prints all addresses as unhashedDocumentation/admin-guide/kernel-parameters.txt lib/test_printf.c lib/vsprintf.c+57 -218 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPetr MladekMarco ElverRandy DunlapSergey SenozhatskyVlastimil Babka
1/3R-b A-b
2/3R-b T-b A-b
3/3A-b A-b A-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v4 thread

Cover letter [PATCH 0/3][v4] add support for never printing hashed addresses

Although hashing addresses printed via printk does make the kernel more secure, it interferes with debugging, especially with some functions like print_hex_dump() which always uses hashed addresses.

To avoid having to choose between %p and %px, it's easier to add a kernel command line that treats all %p as %px. This encourages developers to use %p more without making debugging more difficult.

Patches #1 and #2 upgrade the kselftest framework so that it can report on tests that were skipped outright. This is needed for the test_printf module which will now skip %p hashing tests if hashing is disabled.

Patch #2 upgrades the printf library to check the command line. It also updates test_printf().

Timur Tabi (3):
[v4] lib: use KSTM_MODULE_GLOBALS macro in kselftest drivers [v4] kselftest: add support for skipped tests
[v4] lib/vsprintf: debug_never_hash_pointers prints all addresses as
unhashed

 .../admin-guide/kernel-parameters.txt         | 15 ++++++++
 lib/test_bitmap.c                             |  3 +-
 lib/test_printf.c                             | 12 +++++-
 lib/vsprintf.c                                | 38 ++++++++++++++++++-
 tools/testing/selftests/kselftest_module.h    | 18 ++++++---
 5 files changed, 74 insertions(+), 12 deletions(-)
Signature · 1 line
2.25.1