Skip to content

VM: selftests: Hugepage fixes and cleanups

Sean Christopherson kvm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15KVM: selftests: Explicitly state indicies for vm_guest_mode_params arraytools/testing/selftests/kvm/lib/kvm_util.c+7 -71 reply
2/15KVM: selftests: Expose align() helpers to teststools/testing/selftests/kvm/include/kvm_util.h tools/testing/selftests/kvm/lib/kvm_util.c+16 -101 reply
3/15KVM: selftests: Align HVA for HugeTLB-backed memslotstools/testing/selftests/kvm/lib/kvm_util.c+4 -13 replies
4/15KVM: selftests: Force stronger HVA alignment (1gb) for hugepagestools/testing/selftests/kvm/include/kvm_util.h tools/testing/selftests/kvm/lib/kvm_util.c+14 -32 replies
5/15KVM: selftests: Require GPA to be aligned when backed by hugepagestools/testing/selftests/kvm/lib/kvm_util.c tools/testing/selftests/kvm/lib/perf_test_util.c+11 -01 reply
6/15KVM: selftests: Use shorthand local var to access struct perf_tests_argstools/testing/selftests/kvm/lib/perf_test_util.c+19 -171 reply
7/15KVM: selftests: Capture per-vCPU GPA in perf_test_vcpu_argstools/testing/selftests/kvm/include/perf_test_util.h tools/testing/selftests/kvm/lib/perf_test_util.c+5 -51 reply
8/15KVM: selftests: Use perf util's per-vCPU GPA/pages in demand paging testtools/testing/selftests/kvm/demand_paging_test.c+5 -151 reply
9/15KVM: selftests: Move per-VM GPA into perf_test_argstools/testing/selftests/kvm/include/perf_test_util.h tools/testing/selftests/kvm/lib/perf_test_util.c tools/testing/selftests/kvm/memslot_modification_stress_test.c+13 -255 replies
10/15KVM: selftests: Remove perf_test_args.host_page_sizetools/testing/selftests/kvm/demand_paging_test.c tools/testing/selftests/kvm/include/perf_test_util.h tools/testing/selftests/kvm/lib/perf_test_util.c +1 more+7 -101 reply
11/15KVM: selftests: Create VM with adjusted number of guest pages for perf teststools/testing/selftests/kvm/lib/perf_test_util.c+6 -31 reply
12/15KVM: selftests: Fill per-vCPU struct during "perf_test" VM creationtools/testing/selftests/kvm/demand_paging_test.c tools/testing/selftests/kvm/dirty_log_perf_test.c tools/testing/selftests/kvm/include/perf_test_util.h +2 more+49 -490 replies
13/15KVM: selftests: Sync perf_test_args to guest during VM creationtools/testing/selftests/kvm/demand_paging_test.c tools/testing/selftests/kvm/dirty_log_perf_test.c tools/testing/selftests/kvm/include/perf_test_util.h +2 more+10 -170 replies
14/15KVM: selftests: Track size of per-VM memslot in perf_test_argstools/testing/selftests/kvm/include/perf_test_util.h tools/testing/selftests/kvm/lib/perf_test_util.c+6 -30 replies
15/15KVM: selftests: Get rid of gorilla math in memslots modification testtools/testing/selftests/kvm/memslot_modification_stress_test.c+1 -40 replies

Reviews trailers per patch

9 of 15 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBen GardonAndrew Jones
SeriesR-b
1/15R-b
2/15R-b
3/15R-b
4/15
5/15
6/15R-b
7/15R-b
8/15R-b
9/15R-b
10/15R-b
11/15R-b
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/15] VM: selftests: Hugepage fixes and cleanups

Fix hugepage bugs in the KVM selftests that specifically affect dirty logging and demand paging tests. Found while attempting to verify KVM changes/fixes related to hugepages and dirty logging (patches incoming in a separate series).

Clean up the perf_test_args util on top of the hugepage fixes to clarify what "page size" means, and to improve confidence in the code doing what it thinks it's doing. In a few cases, users of perf_test_args were duplicating (approximating?) calculations made by perf_test_args, and it wasn't obvious that both pieces of code were guaranteed to end up with the same result.

Sean Christopherson (15):
KVM: selftests: Explicitly state indicies for vm_guest_mode_params
array
KVM: selftests: Expose align() helpers to tests
KVM: selftests: Align HVA for HugeTLB-backed memslots
KVM: selftests: Force stronger HVA alignment (1gb) for hugepages
KVM: selftests: Require GPA to be aligned when backed by hugepages
KVM: selftests: Use shorthand local var to access struct
perf_tests_args
KVM: selftests: Capture per-vCPU GPA in perf_test_vcpu_args
KVM: selftests: Use perf util's per-vCPU GPA/pages in demand paging
test
KVM: selftests: Move per-VM GPA into perf_test_args
KVM: selftests: Remove perf_test_args.host_page_size
KVM: selftests: Create VM with adjusted number of guest pages for perf
tests
KVM: selftests: Fill per-vCPU struct during "perf_test" VM creation
KVM: selftests: Sync perf_test_args to guest during VM creation
KVM: selftests: Track size of per-VM memslot in perf_test_args
KVM: selftests: Get rid of gorilla math in memslots modification test

 .../selftests/kvm/demand_paging_test.c        |  39 ++---
 .../selftests/kvm/dirty_log_perf_test.c       |  10 +-
 .../testing/selftests/kvm/include/kvm_util.h  |  28 ++++
 .../selftests/kvm/include/perf_test_util.h    |  18 +--
 tools/testing/selftests/kvm/lib/kvm_util.c    |  36 ++---
 .../selftests/kvm/lib/perf_test_util.c        | 139 ++++++++++--------
 .../kvm/memslot_modification_stress_test.c    |  16 +-
 7 files changed, 145 insertions(+), 141 deletions(-)
Signature · 1 line
2.30.0.478.g8a0d178c01-goog