Skip to content

perf cs-etm: Split Coresight decode by aux records

James Clark linux-arm-kernel linux-perf-users lkml 6 versions – Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest2 patches 14 repliesApplied
  2. v61 patch 1 replySuperseded
  3. v51 patch 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v4 RFC1 patch6 repliesSuperseded
v3 RFC1 patch4 repliesSuperseded
v17 patches12 repliesSuperseded

Changes in v7 from the cover letter

* Fix for snapshot mode where buffers are wrapped. This fix was done by clamping the aux record size to the size of the buffer (see comment).
* Added an extra debugging printout.
* Typo/formatting fixes.
* Add the change for --dump-raw-trace as a second commit. I planned to do this later, but have now finished it so I'll submit it at the same time.
* Did some more thorough testing around the different snapshot scenarios.

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/2perf cs-etm: Split Coresight decode by aux recordstools/perf/util/cs-etm.c+167 -12 replies
2/2perf cs-etm: Split --dump-raw-trace by AUX recordstools/perf/util/cs-etm.c+18 -212 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchLeo YanMathieu Poirier
1/2T-b R-b
2/2T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/2] perf cs-etm: Split Coresight decode by aux records

Change applies to perf/core (45237f9898fc)

Changes since v6:
* Fix for snapshot mode where buffers are wrapped. This fix was done by clamping the aux record size to the size of the buffer (see comment).
* Added an extra debugging printout.
* Typo/formatting fixes.
* Add the change for --dump-raw-trace as a second commit. I planned to do this later, but have now finished it so I'll submit it at the same time.
* Did some more thorough testing around the different snapshot scenarios.

Decoding snapshot files with duplicate data is improved by this patchset because of the reason mentioned at the end of the testing section. Coincidentally, the same issue is also fixed in "[PATCH v1 0/3] coresight: Fix for snapshot mode" but by not saving duplicates, rather than not decoding them.

James Clark (2):
perf cs-etm: Split Coresight decode by aux records perf cs-etm: Split --dump-raw-trace by AUX records

 tools/perf/util/cs-etm.c | 188 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 185 insertions(+), 3 deletions(-)
Signature · 1 line
2.28.0