Add BTF_KIND_FLOAT support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest10 patches 3 repliesIn review
- v69 patches 12 repliesSuperseded
- v58 patches 5 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 7 patches | 6 replies | Superseded | |
| v3 | 6 patches | 6 replies | Superseded | |
| v2 | 6 patches | 9 replies | Superseded | |
| v1 | 6 patches | 12 replies | Superseded |
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | bpf: Add BTF_KIND_FLOAT to uapiinclude/ tools/ | +6 | 0 replies | |
| 2/10 | libbpf: Fix whitespace in btf_add_composite() commenttools/ | +1 | 1 reply | |
| 3/10 | libbpf: Add BTF_KIND_FLOAT supporttools/ tools/ tools/ +3 more | +94 | 0 replies | |
| 4/10 | tools/bpftool: Add BTF_KIND_FLOAT supporttools/ tools/ | +9 | 0 replies | |
| 5/10 | selftests/bpf: Use the 25th bit in the "invalid BTF_INFO" testtools/ | +1 | 0 replies | |
| 6/10 | bpf: Add BTF_KIND_FLOAT supportkernel/ | +81 | 1 reply | |
| 7/10 | selftest/bpf: Add BTF_KIND_FLOAT teststools/ tools/ tools/ | +138 | 0 replies | |
| 8/10 | selftests/bpf: Add BTF_KIND_FLOAT to the existing deduplication teststools/ | +31 | 0 replies | |
| 9/10 | selftests/bpf: Add BTF_KIND_FLOAT to test_core_reloc_sizetools/ tools/ tools/ | +9 | 0 replies | |
| 10/10 | bpf: Document BTF_KIND_FLOAT in btf.rstDocumentation/ | +15 | 0 replies |
Reviews trailers per patch
9 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Yonghong Song | Andrii Nakryiko |
|---|---|---|
| 1/10 | A-b | |
| 2/10 | A-b | |
| 3/10 | A-b | |
| 4/10 | A-b | |
| 5/10 | A-b | |
| 6/10 | A-b | |
| 7/10 | A-b | A-b |
| 8/10 | A-b | |
| 9/10 | ||
| 10/10 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v7 bpf-next 00/10] Add BTF_KIND_FLOAT support
Some BPF programs compiled on s390 fail to load, because s390 arch-specific linux headers contain float and double types.
Introduce support for such types by representing them using the new BTF_KIND_FLOAT. This series deals with libbpf, bpftool, in-kernel BTF parser as well as selftests and documentation.
There are also pahole and LLVM parts:
* https://github.com/iii-i/dwarves/commit/btf-kind-float-v2
* https://reviews.llvm.org/D83289
but they should go in after the libbpf part is integrated.
---
v0: https://lore.kernel.org/bpf/[email protected]/
v0 -> v1: Per Andrii's suggestion, remove the unnecessary trailing u32.
v1: https://lore.kernel.org/bpf/[email protected]/
v1 -> v2: John noticed that sanitization corrupts BTF, because new and
old sizes don't match. Per Yonghong's suggestion, use a modifier type (which has the same size as the float type) as a replacement.
Per Yonghong's suggestion, add size and alignment checks to the kernel BTF parser.
v2: https://lore.kernel.org/bpf/[email protected]/
v2 -> v3: Based on Yonghong's suggestions: Use BTF_KIND_CONST instead of
BTF_KIND_TYPEDEF and make sure that the C code generated from the sanitized BTF is well-formed; fix size calculation in tests and use NAME_TBD everywhere; limit allowed sizes to 2, 4, 8, 12 and 16 (this should also fix m68k and nds32le builds).
v3: https://lore.kernel.org/bpf/[email protected]/
v3 -> v4: More fixes for the Yonghong's findings: fix the outdated
comment in bpf_object__sanitize_btf() and add the error handling there (I've decided to check uint_id and uchar_id too in order to simplify debugging); add bpftool output example; use div64_u64_rem() instead of % in order to fix the linker error.
Also fix the "invalid BTF_INFO" test (new commit, #4).
v4: https://lore.kernel.org/bpf/[email protected]/
v4 -> v5: Fixes for the Andrii's findings: Use BTF_KIND_STRUCT instead
of BTF_KIND_TYPEDEF for sanitization; check byte_sz in libbpf; move btf__add_float; remove relo support; add a dedup test (new commit, #7).
v5: https://lore.kernel.org/bpf/[email protected]/
v5 -> v6: Fixes for further findings by Andrii: split whitespace issue
fix into a separate patch; add 12-byte float to "float test #1, well-formed".
v6: https://lore.kernel.org/bpf/[email protected]/
v6 -> v7: John suggested to add a comment explaining why sanitization
does not preserve the type name, as well as what effect it has on running the code on the older kernels.
Yonghong has asked to add a comment explaining why we are not checking the alignment very precisely in the kernel. John suggested to add a bpf_core_field_size test (commit #9).
Based on Alexei's feedback [1] I'm proceeding with the BTF_KIND_FLOAT approach.
[1] https://lore.kernel.org/bpf/CAADnVQKWPODWZ2RSJ5FJhfYpxkuV0cvSAL1O+FSr9oP1ercoBg@mail.gmail.com/
Ilya Leoshkevich (10):
bpf: Add BTF_KIND_FLOAT to uapi
libbpf: Fix whitespace in btf_add_composite() comment
libbpf: Add BTF_KIND_FLOAT support
tools/bpftool: Add BTF_KIND_FLOAT support
selftests/bpf: Use the 25th bit in the "invalid BTF_INFO" test
bpf: Add BTF_KIND_FLOAT support
selftest/bpf: Add BTF_KIND_FLOAT tests
selftests/bpf: Add BTF_KIND_FLOAT to the existing deduplication tests selftests/bpf: Add BTF_KIND_FLOAT to test_core_reloc_size
bpf: Document BTF_KIND_FLOAT in btf.rst
Documentation/bpf/btf.rst | 17 +- include/uapi/linux/btf.h | 5 +- kernel/bpf/btf.c | 83 ++++++++- tools/bpf/bpftool/btf.c | 8 + tools/bpf/bpftool/btf_dumper.c | 1 + tools/include/uapi/linux/btf.h | 5 +- tools/lib/bpf/btf.c | 51 ++++- tools/lib/bpf/btf.h | 6 + tools/lib/bpf/btf_dump.c | 4 + tools/lib/bpf/libbpf.c | 29 ++- tools/lib/bpf/libbpf.map | 5 + tools/lib/bpf/libbpf_internal.h | 2 + tools/testing/selftests/bpf/btf_helpers.c | 4 + tools/testing/selftests/bpf/prog_tests/btf.c | 176 ++++++++++++++++-- .../selftests/bpf/prog_tests/core_reloc.c | 1 + .../selftests/bpf/progs/core_reloc_types.h | 5 + .../bpf/progs/test_core_reloc_size.c | 3 + tools/testing/selftests/bpf/test_btf.h | 3 + 18 files changed, 385 insertions(+), 23 deletions(-)
Signature · 1 line
2.29.2