Skip to content

hw/accel: Exit gracefully when accelerator is invalid

Philippe Mathieu-Daudé kvm qemu-arm qemu-devel xen-devel 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 20 repliesIn review
  2. v17 patches 12 repliesSuperseded

Changes in v2 from the cover letter

- added missing x86 arch (Peter)
- consider all accelerators (Daniel and Peter)
- do not enable KVM on sbsa-ref (Leif)
- updated 'query-machines' (Daniel)
- new patch for XenPV

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11accel/kvm: Check MachineClass kvm_type() return valueaccel/kvm/kvm-all.c include/hw/boards.h+8 -18 replies
2/11hw/boards: Introduce machine_class_valid_for_accelerator()hw/core/machine.c include/hw/boards.h+50 -03 replies
3/11hw/core: Restrict 'query-machines' to those supported by current accelhw/core/machine-qmp-cmds.c+4 -01 reply
4/11hw/arm: Restrit KVM to the virt & versal machineshw/arm/virt.c hw/arm/xlnx-versal-virt.c+10 -01 reply
5/11hw/mips: Restrict KVM to the malta & virt machineshw/mips/loongson3_virt.c hw/mips/malta.c+10 -02 replies
6/11hw/ppc: Restrict KVM to various PPC machineshw/ppc/e500plat.c hw/ppc/mac_newworld.c hw/ppc/mac_oldworld.c +5 more+41 -02 replies
7/11hw/s390x: Explicit the s390-ccw-virtio machines support TCG and KVMhw/s390x/s390-virtio-ccw.c+5 -01 reply
8/11hw/i386: Explicit x86 machines support all current acceleratorshw/i386/x86.c+5 -00 replies
9/11hw/xenpv: Restrict Xen Para-virtualized machine to Xen acceleratorhw/xenpv/xen_machine_pv.c+5 -01 reply
10/11hw/board: Only allow TCG accelerator by defaulthw/core/machine.c include/hw/boards.h+6 -60 replies
11/11softmmu/vl: Exit gracefully when accelerator is not supportedsoftmmu/vl.c+7 -01 reply

Reviews trailers per patch

4 of 11 patches have a Reviewed-by or Acked-by.

PatchPaul DurrantJiaxun YangHuacai ChenCornelia Huck
1/11
2/11
3/11R-b
4/11
5/11R-b R-b
6/11
7/11R-b
8/11
9/11A-b
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/11] hw/accel: Exit gracefully when accelerator is invalid

Hi,

This series aims to improve user experience by providing a better error message when the user tries to enable KVM on machines not supporting it.

Since v1:
- added missing x86 arch (Peter)
- consider all accelerators (Daniel and Peter)
- do not enable KVM on sbsa-ref (Leif)
- updated 'query-machines' (Daniel)
- new patch for XenPV

Supersedes: <[email protected]>

Philippe Mathieu-Daudé (11):
accel/kvm: Check MachineClass kvm_type() return value hw/boards: Introduce machine_class_valid_for_accelerator() hw/core: Restrict 'query-machines' to those supported by current accel hw/arm: Restrit KVM to the virt & versal machines
hw/mips: Restrict KVM to the malta & virt machines
hw/ppc: Restrict KVM to various PPC machines
hw/s390x: Explicit the s390-ccw-virtio machines support TCG and KVM hw/i386: Explicit x86 machines support all current accelerators hw/xenpv: Restrict Xen Para-virtualized machine to Xen accelerator hw/board: Only allow TCG accelerator by default softmmu/vl: Exit gracefully when accelerator is not supported

 include/hw/boards.h        | 27 ++++++++++++++++++++++++++-
 accel/kvm/kvm-all.c        |  6 ++++++
 hw/arm/virt.c              |  5 +++++
 hw/arm/xlnx-versal-virt.c  |  5 +++++
 hw/core/machine-qmp-cmds.c |  4 ++++
 hw/core/machine.c          | 26 ++++++++++++++++++++++++++
 hw/i386/x86.c              |  5 +++++
 hw/mips/loongson3_virt.c   |  5 +++++
 hw/mips/malta.c            |  5 +++++
 hw/ppc/e500plat.c          |  5 +++++
 hw/ppc/mac_newworld.c      |  6 ++++++
 hw/ppc/mac_oldworld.c      |  5 +++++
 hw/ppc/mpc8544ds.c         |  5 +++++
 hw/ppc/ppc440_bamboo.c     |  5 +++++
 hw/ppc/prep.c              |  5 +++++
 hw/ppc/sam460ex.c          |  5 +++++
 hw/ppc/spapr.c             |  5 +++++
 hw/s390x/s390-virtio-ccw.c |  5 +++++
 hw/xenpv/xen_machine_pv.c  |  5 +++++
 softmmu/vl.c               |  7 +++++++
 20 files changed, 145 insertions(+), 1 deletion(-)
Signature · 1 line
2.26.2