xfs: Skip repetitive warnings about mount options
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest posting 2/22 patches 1 replyIn review
- v2 posting 1/22 patches 4 repliesSuperseded
- v11 patch 7 repliesSuperseded
V2 vs. V1 from the cover letter
* Added new patch that renames mp to parsing_mp in xfs_fs_parse_param()
* Added new function xfs_fs_warn_deprecated() to encapsulate the logic for displaying the deprecation warning.
* Fixed some white space issues.
Patches in v2 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | xfs: rename variable mp to parsing_mpfs/ | +51 | 0 replies | |
| 2/2 | xfs: Skip repetitive warnings about mount optionsfs/ | +20 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Darrick J. Wong | Carlos Maiolino | Eric Sandeen |
|---|---|---|---|
| 1/2 | R-b | R-b | |
| 2/2 | R-b | R-b | Fix-suggested-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 0/2] xfs: Skip repetitive warnings about mount options
Hello,
I belive that this patch set was missed in recent for-next branch update.
Patches are the same as before I just added the reviewed-by tags.
Thanks!
...
At least some version of mount will look in /proc/mounts and send in all of the options that it finds as part of a remount command. We also /do/ still emit "attr2" in /proc/mounts (as we probably should), so remount passes that back in, and we emit a warning, which is not great.
In other words mount passes in "attr2" and the kernel emits a deprecation warning for attr2, even though the user/admin never explicitly asked for the option.
So, lets skip the warning if (we are remounting && deprecated option state is not changing).
I also attached test for xfstests that I used for testing (the test will be proposed on xfstests-list after/if this patch is merged).
V2 vs. V1
* Added new patch that renames mp to parsing_mp in xfs_fs_parse_param()
* Added new function xfs_fs_warn_deprecated() to encapsulate the logic for displaying the deprecation warning.
* Fixed some white space issues.
Pavel Reichl (2):
xfs: rename variable mp to parsing_mp
xfs: Skip repetitive warnings about mount options
fs/xfs/xfs_super.c | 118 +++++++++++++++++++++++++-------------------- 1 file changed, 67 insertions(+), 51 deletions(-)
Signature · 1 line
2.30.2