Skip to content

virtiofsd: Add support to enable/disable posix acls

Vivek Goyal qemu-devel virtio-fs 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest7 patches 20 repliesIn review
  2. v6 posting 2/28 patches 0 repliesSuperseded
  3. v6 posting 1/25 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v55 patches3 repliesSuperseded
v43 patches0 repliesSuperseded
v32 patches3 repliesSuperseded

Changes in v7 from the cover letter

- Dropped kernel header update patch as somebody else did it.
- Fixed coding style issues.

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7virtiofsd: Fix fuse setxattr() API change issuetools/virtiofsd/fuse_common.h tools/virtiofsd/fuse_lowlevel.c+11 -14 replies
2/7virtiofsd: Fix xattr operations overwriting errnotools/virtiofsd/passthrough_ll.c+10 -64 replies
3/7virtiofsd: Add support for extended setxattrtools/virtiofsd/fuse_common.h tools/virtiofsd/fuse_lowlevel.c tools/virtiofsd/fuse_lowlevel.h +1 more+19 -33 replies
4/7virtiofsd: Add umask to seccom allow listtools/virtiofsd/passthrough_seccomp.c+1 -00 replies
5/7virtiofsd: Add capability to change/restore umasktools/virtiofsd/passthrough_ll.c+16 -65 replies
6/7virtiofsd: Switch creds, drop FSETID for system.posix_acl_access xattrtools/virtiofsd/passthrough_ll.c+75 -02 replies
7/7virtiofsd: Add an option to enable/disable posix aclsdocs/tools/virtiofsd.rst tools/virtiofsd/helper.c tools/virtiofsd/passthrough_ll.c+118 -11 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchStefan HajnocziDr. David Alan GilbertGreg Kurz
1/7R-b R-b
2/7R-b R-b
3/7R-b
4/7R-b
5/7R-b R-b
6/7R-b R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH v7 0/7] virtiofsd: Add support to enable/disable posix acls

Hi,

This is V7 of the patches.

Changes since V6.

- Dropped kernel header update patch as somebody else did it.
- Fixed coding style issues.

Currently posix ACL support does not work well with virtiofs and bunch of tests fail when I run xfstests "./check -g acl".

This patches series fixes the issues with virtiofs posix acl support and provides options to enable/disable posix acl (-o posix_acl/no_posix_acl). By default posix_acls are disabled.

With this patch series applied and virtiofsd running with "-o posix_acl", xfstests "./check -g acl" passes.

Thanks
Vivek

Vivek Goyal (7):
virtiofsd: Fix fuse setxattr() API change issue
virtiofsd: Fix xattr operations overwriting errno
virtiofsd: Add support for extended setxattr
virtiofsd: Add umask to seccom allow list
virtiofsd: Add capability to change/restore umask
virtiofsd: Switch creds, drop FSETID for system.posix_acl_access xattr
virtiofsd: Add an option to enable/disable posix acls

 docs/tools/virtiofsd.rst              |   3 +
 tools/virtiofsd/fuse_common.h         |  10 ++
 tools/virtiofsd/fuse_lowlevel.c       |  18 +-
 tools/virtiofsd/fuse_lowlevel.h       |   3 +-
 tools/virtiofsd/helper.c              |   1 +
 tools/virtiofsd/passthrough_ll.c      | 229 ++++++++++++++++++++++++--
 tools/virtiofsd/passthrough_seccomp.c |   1 +
 7 files changed, 249 insertions(+), 16 deletions(-)
Signature · 1 line
2.25.4