nvme: fixup MD RAID usage
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest2 patches 5 repliesIn review
Changes to v1 from the cover letter
- Integrated reviews from Sagi
- Use fast_io_fail_tmo instead of a new sysfs attribute
- Rename attribute to 'no_path_detach'
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | nvme: add 'fast_io_fail_tmo' controller sysfs attributedrivers/ | +32 | 1 reply | |
| 2/2 | nvme: delete disk when last path is gonedrivers/ drivers/ drivers/ | +56 | 3 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Keith Busch | Minwoo Im | Sagi Grimberg |
|---|---|---|---|
| Series | R-b | ||
| 1/2 | R-b | ||
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCHv2 0/2] nvme: fixup MD RAID usage
Hi all,
ever since the implementation NVMe-oF does not work together with MD RAID. MD RAID expects the device to return an I/O error on failure, and to remove the block device if the underlying hardware is removed.
This is contrary to the implementation of NVMe-oF, which will keep on retrying I/O while the controller is being reset, and will only remove the block device once the last _user_ is gone.
While we already have a 'fast_io_fail_tmo' setting which would ensure that I/O errors are returned after the timeout expired, this attribute has to be set during the initial 'connect' call.
So the first patch adds a 'fasi_io_fail_tmo' controller sysfs attribute which allows the admin to modify it during runtime. To fixup the second issue a new attribute 'no_path_detach' is implemented, which will cause the disk to be removed as once the last controller holding a path to the namespace is removed (ie after all reconnect attempts for that controllers are exhausted).
This is a rework of the earlier path by Keith Busch ('nvme-mpath: delete disk after last connection'). Kudos to him for suggesting this approach.
Changes to v1:
- Integrated reviews from Sagi
- Use fast_io_fail_tmo instead of a new sysfs attribute
- Rename attribute to 'no_path_detach'
Hannes Reinecke (2):
nvme: add 'fast_io_fail_tmo' controller sysfs attribute
nvme: delete disk when last path is gone
drivers/nvme/host/core.c | 41 ++++++++++++++++++++++++++++++++++- drivers/nvme/host/multipath.c | 31 +++++++++++++++++++++++++- drivers/nvme/host/nvme.h | 21 +++++++++++++++--- 3 files changed, 88 insertions(+), 5 deletions(-)
Signature · 7 lines
2.29.2 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme