Skip to content

drm/vc4: hdmi: Support the 4k @ 60Hz modes

Maxime Ripard dri-devel lkml 8 versions – Applied

Status from this message: Applied to drm/drm-misc (drm-misc-next).

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest10 patches 10 repliesApplied
  2. v710 patches 0 repliesSuperseded
  3. v610 patches 0 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v510 patches0 repliesSuperseded
v412 patches7 repliesSuperseded
v39 patches0 repliesSuperseded
v25 patches6 repliesSuperseded
v18 patches15 repliesSuperseded

Changes in v8 from the cover letter

- Rebased on current drm-misc-next

Patches in v8 Applied

#Subject and filesSizeRepliesApplied
1/10drm/vc4: hdmi: Remove the DDC probing for status detectiondrivers/gpu/drm/vc4/vc4_hdmi.c+0 -21 reply
2/10drm/vc4: hdmi: Fix HPD GPIO detectiondrivers/gpu/drm/vc4/vc4_hdmi.c+3 -31 reply
3/10drm/vc4: Make vc4_crtc_get_encoder publicdrivers/gpu/drm/vc4/vc4_crtc.c drivers/gpu/drm/vc4/vc4_drv.h+9 -41 reply
4/10drm/vc4: crtc: Add encoder to vc4_crtc_config_pv prototypedrivers/gpu/drm/vc4/vc4_crtc.c+3 -41 reply
5/10drm/vc4: crtc: Rework the encoder retrieval code (again)drivers/gpu/drm/vc4/vc4_crtc.c drivers/gpu/drm/vc4/vc4_drv.h+10 -241 reply
6/10drm/vc4: crtc: Add some loggingdrivers/gpu/drm/vc4/vc4_crtc.c+6 -01 reply
7/10drm/vc4: Leverage the load tracker on the BCM2711drivers/gpu/drm/vc4/vc4_debugfs.c drivers/gpu/drm/vc4/vc4_drv.h drivers/gpu/drm/vc4/vc4_kms.c +1 more+10 -211 reply
8/10drm/vc4: hdmi: Raise the maximum clock ratedrivers/gpu/drm/vc4/vc4_hdmi.c+1 -10 replies
9/10drm/vc4: hdmi: Enable the scrambler on reconnectiondrivers/gpu/drm/vc4/vc4_hdmi.c+3 -01 reply
10/10drm/vc4: Increase the core clock based on HVS loaddrivers/gpu/drm/vc4/vc4_crtc.c drivers/gpu/drm/vc4/vc4_drv.h drivers/gpu/drm/vc4/vc4_kms.c+118 -91 reply

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchThomas ZimmermannDave Stevenson
1/10R-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10A-b R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 00/10] drm/vc4: hdmi: Support the 4k @ 60Hz modes

Hi,

Here is a series that enables the higher resolutions on the HDMI0 Controller found in the BCM2711 (RPi4).

In order to work it needs a few adjustments to config.txt, most notably to enable the enable_hdmi_4kp60 option.

Let me know what you think,
Maxime

---

Changes from v7:
- Rebased on current drm-misc-next

Changes from v6:
- Rebased on current drm-misc-next
- Removed stale clk_request pointer

Changes from v5:
- Fixed unused variables warning

Changes from v4:
- Removed the patches already applied
- Added various fixes for the issues that have been discovered on the downstream tree

Changes from v3:
- Rework the encoder retrieval code that was broken on the RPi3 and older
- Fix a scrambling enabling issue on some display

Changes from v2:
- Gathered the various tags
- Added Cc stable when relevant
- Split out the check to test whether the scrambler is required into an helper
- Fixed a bug where the scrambler state wouldn't be tracked properly if it was enabled at boot

Changes from v1:
- Dropped the range accessors
- Drop the mention of force_turbo
- Reordered the SCRAMBLER_CTL register to match the offset
- Removed duplicate HDMI_14_MAX_TMDS_CLK define
- Warn about enable_hdmi_4kp60 only if there's some modes that can't be reached
- Rework the BVB clock computation

Maxime Ripard (10):
drm/vc4: hdmi: Remove the DDC probing for status detection drm/vc4: hdmi: Fix HPD GPIO detection
drm/vc4: Make vc4_crtc_get_encoder public drm/vc4: crtc: Add encoder to vc4_crtc_config_pv prototype drm/vc4: crtc: Rework the encoder retrieval code (again) drm/vc4: crtc: Add some logging
drm/vc4: Leverage the load tracker on the BCM2711 drm/vc4: hdmi: Raise the maximum clock rate drm/vc4: hdmi: Enable the scrambler on reconnection drm/vc4: Increase the core clock based on HVS load

 drivers/gpu/drm/vc4/vc4_crtc.c    |  60 ++++++++------
 drivers/gpu/drm/vc4/vc4_debugfs.c |   7 +-
 drivers/gpu/drm/vc4/vc4_drv.h     |   8 +-
 drivers/gpu/drm/vc4/vc4_hdmi.c    |  13 +--
 drivers/gpu/drm/vc4/vc4_kms.c     | 126 +++++++++++++++++++++++++-----
 drivers/gpu/drm/vc4/vc4_plane.c   |   5 --
 6 files changed, 157 insertions(+), 62 deletions(-)
Signature · 1 line
2.31.1