Skip to content

gpio: pca953x: Better quirk for Intel Galileo Gen 2

Andy Shevchenko linux-acpi linux-gpio lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3gpiolib: acpi: Add ACPI_GPIO_QUIRK_ABSOLUTE_NUMBER quirkdrivers/gpio/gpiolib-acpi.c include/linux/gpio/consumer.h+8 -16 replies
2/3gpiolib: acpi: Allow to find GpioInt() resource by name and indexdrivers/gpio/gpiolib-acpi.c include/linux/acpi.h+16 -61 reply
3/3gpio: pca953x: Set IRQ type when handle Intel Galileo Gen 2drivers/gpio/gpio-pca953x.c+23 -551 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchLinus Walleij
1/3A-b
2/3A-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 0/3] gpio: pca953x: Better quirk for Intel Galileo Gen 2

It appears that after commit to the gpio-dwapb driver the quirk for Intel Galileo Gen 2 stopped working. I tried a few approaches but none of them worked besides the fact that they copy like a ~10% of the gpiolib-acpi functionality.

Instead I decided to come back to a mix of v1 [1] of the initial series (the v3 has been applied) and Mika's suggestion about using gpio_to_desc() API.

Unfortunately it requires to have a quirk in the core, but in comparison to v1 it much less intrusive and doesn't use any predefined numbers.

I would like to create an immutable branch and send TWIMC (GPIO and ACPI subsystems I guess). This is material for v5.12-rcX.

[1]: https://lore.kernel.org/linux-gpio/[email protected]/

Andy Shevchenko (3):
gpiolib: acpi: Add ACPI_GPIO_QUIRK_ABSOLUTE_NUMBER quirk
gpiolib: acpi: Allow to find GpioInt() resource by name and index
gpio: pca953x: Set IRQ type when handle Intel Galileo Gen 2

 drivers/gpio/gpio-pca953x.c   | 78 +++++++++++------------------------
 drivers/gpio/gpiolib-acpi.c   | 19 ++++++---
 include/linux/acpi.h          | 10 ++++-
 include/linux/gpio/consumer.h |  2 +
 4 files changed, 47 insertions(+), 62 deletions(-)
Signature · 1 line
2.30.0