V4L2 stateless VP8 de-staging
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest8 patches 0 repliesNew
- v28 patches 1 replySuperseded
- v17 patches 1 replySuperseded
Changes in v3 from the cover letter
* Rebased on latest media/master branch.
* Rename "seg" field to "segment" as noted by Alex, (thanks!)
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | media: uapi: vp8: Remove "header" from symbol names and macrosDocumentation/ Documentation/ drivers/ +11 more | +192 | 0 replies | |
| 2/8 | media: uapi: vp8: Rename v4l2_vp8_loopfilter to v4l2_vp8_loop_filterDocumentation/ drivers/ drivers/ +1 more | +10 | 0 replies | |
| 3/8 | media: uapi: vp8: Add proper kernel-doc documentationinclude/ | +99 | 0 replies | |
| 4/8 | media: uapi: Move parsed VP8 pixel format out of stagingDocumentation/ include/ include/ | +1 | 0 replies | |
| 5/8 | media: uapi: Move the VP8 stateless control type out of staginginclude/ include/ | +2 | 0 replies | |
| 6/8 | media: controls: Log VP8 stateless control in .std_logdrivers/ | +3 | 0 replies | |
| 7/8 | media: vp8: Rename V4L2 VP8 specific macro to V4L2_VP8_drivers/ drivers/ drivers/ +1 more | +13 | 0 replies | |
| 8/8 | media: uapi: move VP8 stateless controls out of stagingDocumentation/ Documentation/ Documentation/ +14 more | +555 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/8] V4L2 stateless VP8 de-staging
After close scrutiny of the VP8 specification, it seems the VP8 stateless API is ready.
This series contains a series of clean-ups and improvement:
renaming symbols for consistency, documenting things for clarity, and then moves the control to proper V4L2 headers.
It must be noted that, unlike parsed H.264, V4L2_PIX_FMT_VP8_FRAME buffers must contain the VP8 frame header. In others words a VP8 parsed frame buffer is:
+--------+-----------------------------------------------------+-----+------------+ | tag 3B | extra 7B | header | MB data | DCT size | DCT part 0 | ... | DCT part N | +--------+-----------------------------------------------------+-----+------------+
Hopefully the pixel format documentation is now clear about that.
Support in Cedrus and Hantro is available upstream, and Mediatek support is available downstream [1] which uses the API as-is.
This was tested with GStreamer v4l2codec [2] element and Fluster [3] conformance test, on a Hantro G1 device.
Changelog:
v3:
* Rebased on latest media/master branch.
* Rename "seg" field to "segment" as noted by Alex, (thanks!)
v2: * Rename VP8_FRAME_IS_KEY_FRAME
[1] https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2614338/21/
[2] https://gitlab.freedesktop.org/ezequielgarcia/gst-plugins-bad/-/tree/vp8-api-update
[3] https://github.com/fluendo/fluster
Ezequiel Garcia (8):
media: uapi: vp8: Remove "header" from symbol names and macros
media: uapi: vp8: Rename v4l2_vp8_loopfilter to v4l2_vp8_loop_filter
media: uapi: vp8: Add proper kernel-doc documentation
media: uapi: Move parsed VP8 pixel format out of staging
media: uapi: Move the VP8 stateless control type out of staging
media: controls: Log VP8 stateless control in .std_log
media: vp8: Rename V4L2 VP8 specific macro to V4L2_VP8_
media: uapi: move VP8 stateless controls out of staging
.../media/v4l/ext-ctrls-codec-stateless.rst | 334 +++++++++++++++++ .../media/v4l/ext-ctrls-codec.rst | 339 ------------------ .../media/v4l/pixfmt-compressed.rst | 15 +- .../media/v4l/vidioc-g-ext-ctrls.rst | 4 + .../media/v4l/vidioc-queryctrl.rst | 6 + .../media/videodev2.h.rst.exceptions | 1 + drivers/media/v4l2-core/v4l2-ctrls.c | 39 +- drivers/staging/media/hantro/hantro_drv.c | 2 +- .../staging/media/hantro/hantro_g1_vp8_dec.c | 55 ++- drivers/staging/media/hantro/hantro_hw.h | 2 +- drivers/staging/media/hantro/hantro_vp8.c | 10 +- .../media/hantro/rk3399_vpu_hw_vp8_dec.c | 55 ++- drivers/staging/media/sunxi/cedrus/cedrus.c | 2 +- drivers/staging/media/sunxi/cedrus/cedrus.h | 2 +- .../staging/media/sunxi/cedrus/cedrus_dec.c | 2 +- .../staging/media/sunxi/cedrus/cedrus_vp8.c | 113 +++--- include/media/v4l2-ctrls.h | 5 +- include/media/vp8-ctrls.h | 114 ------ include/uapi/linux/v4l2-controls.h | 195 ++++++++++ include/uapi/linux/videodev2.h | 4 + 20 files changed, 693 insertions(+), 606 deletions(-) delete mode 100644 include/media/vp8-ctrls.h
Signature · 1 line
2.30.0