Some minor fixes/additions for nvme-cli
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest9 patches 0 repliesNew
- v110 patches 19 repliesSuperseded
Changes in v2 from the cover letter
- rebased on current upstream
- squashed previous patches 1 and 2 into one, and simplified the logic (Sagi) - if the kernel has no "kato" attribute, we now simply assume that existing discovery controllers we encounter are persistent.
- added Reviewed-by: trailers where appropriate
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | nvme-discover: lookup existing persistent controllersfabrics.c | +32 | 0 replies | |
| 2/9 | do_discover: free cfg.device when resetting itfabrics.c | +12 | 0 replies | |
| 3/9 | nvme-connect-all(1): fix documentation for --quiet/-SDocumentation/ Documentation/ Documentation/ | +11 | 0 replies | |
| 4/9 | nvme: add some simplifying macros for __attribute__((cleanup()))Makefile util/ util/ | +23 | 0 replies | |
| 5/9 | nvme-cli: add generic logging functionalityMakefile fabrics.c util/ +1 more | +172 | 0 replies | |
| 6/9 | nvme: convert some function arguments from "char *" to "const char *"fabrics.c nvme-topology.c nvme.c +1 more | +19 | 0 replies | |
| 7/9 | fabrics: use "const char *" in struct configfabrics.c | +9 | 0 replies | |
| 8/9 | fabrics: fix some memory leaksfabrics.c | +17 | 0 replies | |
| 9/9 | fabrics: fix invalid memory access in discover_from_conf_file()fabrics.c | +5 | 0 replies |
Reviews trailers per patch
6 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Chaitanya Kulkarni | Sagi Grimberg |
|---|---|---|
| 1/9 | ||
| 2/9 | ||
| 3/9 | R-b | R-b |
| 4/9 | R-b | R-b |
| 5/9 | R-b | |
| 6/9 | R-b | R-b |
| 7/9 | R-b | R-b |
| 8/9 | R-b | R-b |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/9] Some minor fixes/additions for nvme-cli
From: Martin Wilck <[email protected]>
This series collects patches from my former submission "RFC: add "nvme monitor" subcommand" which aren't directly related to the monitor functionality, but required to make the monitor in its current form compile. A v3 of the monitor code is about to follow.
The main part is the "generic logging functionality".
Changes wrt the RFC: add "nvme monitor" subcommand series: many.
- rebased to current upstream code base e9d43dd ("[nvme-cli] Fix Max/Min User data erase counts displayed in 0xC2 Log Page"))
- renamed log() to msg() in order to prevent name clash with <math.h>
- put logging and cleanup files in "util/" subdirectory
- converted the bulk of the logging code from a macro into a function (Hannes)
- added functionality to optionally log the PID (default off).
- added Hannes' patch he recently submitted via github
(https://github.com/linux-nvme/nvme-cli/pull/942), with two minor fixes on top, rationale in the commit messages
- various additional fixes for memory handling
Both cleanup and logging functions / macros could be used in more places with positive effects, but my focus is currently on preparing the monitor functionality.
Changes v1 -> v2:
- rebased on current upstream
- squashed previous patches 1 and 2 into one, and simplified the logic (Sagi) - if the kernel has no "kato" attribute, we now simply assume that existing discovery controllers we encounter are persistent.
- added Reviewed-by: trailers where appropriate
Hannes Reinecke / Martin Wilck (1):
nvme-discover: lookup existing persistent controllers
Martin Wilck (8):
do_discover: free cfg.device when resetting it nvme-connect-all(1): fix documentation for --quiet/-S
nvme: add some simplifying macros for __attribute__((cleanup()))
nvme-cli: add generic logging functionality
nvme: convert some function arguments from "char *" to "const char *"
fabrics: use "const char *" in struct config
fabrics: fix some memory leaks
fabrics: fix invalid memory access in discover_from_conf_file()
Documentation/nvme-connect-all.1 | 8 +- Documentation/nvme-connect-all.html | 10 +- Documentation/nvme-connect-all.txt | 4 +- Makefile | 3 +- fabrics.c | 218 +++++++++++++++++----------- nvme-topology.c | 2 +- nvme.c | 2 +- nvme.h | 4 +- util/cleanup.c | 4 + util/cleanup.h | 18 +++ util/log.c | 90 ++++++++++++ util/log.h | 34 +++++ 12 files changed, 295 insertions(+), 102 deletions(-) create mode 100644 util/cleanup.c create mode 100644 util/cleanup.h create mode 100644 util/log.c create mode 100644 util/log.h
Signature · 7 lines
2.30.1 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme