Skip to content

userfaultfd/selftests: A few cleanups

Peter Xu linux-mm lkml 2 versions – Applied

Status from this message: [merged] userfaultfd-selftests-unify-error-handling.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 0 repliesApplied 5/5
  2. v15 patches 1 replySuperseded

Changes in v2 from the cover letter

- rebase to v5.12-rc7-mmots-2021-04-11-20-49
- collect r-bs from Axel

Patches in v2 All 5 applied

#Subject and filesSizeRepliesApplied
1/5userfaultfd/selftests: Use user mode onlytools/testing/selftests/vm/userfaultfd.c+1 -10 repliesApplied
2/5userfaultfd/selftests: Remove the time() check on delayed uffdtools/testing/selftests/vm/userfaultfd.c+0 -80 repliesApplied
3/5userfaultfd/selftests: Dropping VERIFY check in locking_threadtools/testing/selftests/vm/userfaultfd.c+1 -540 repliesApplied
4/5userfaultfd/selftests: Only dump counts if mode enabledtools/testing/selftests/vm/userfaultfd.c+20 -100 repliesApplied
5/5userfaultfd/selftests: Unify error handlingtools/testing/selftests/vm/userfaultfd.c+187 -3690 repliesApplied

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchAxel Rasmussen
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] userfaultfd/selftests: A few cleanups

v2:
- rebase to v5.12-rc7-mmots-2021-04-11-20-49
- collect r-bs from Axel

I wanted to cleanup userfaultfd.c fault handling for a long time. If it's not cleaned, when the new code grows the file it'll also grow the size that needs to be cleaned... This is my attempt to cleanup the userfaultfd selftest on fault handling, to use an err() macro instead of either fprintf() or perror() then another exit() call.

The huge cleanup is done in the last patch. The first 4 patches are some other standalone cleanups for the same file, so I put them together.

Please review, thanks.

Peter Xu (5):
userfaultfd/selftests: Use user mode only userfaultfd/selftests: Remove the time() check on delayed uffd userfaultfd/selftests: Dropping VERIFY check in locking_thread userfaultfd/selftests: Only dump counts if mode enabled userfaultfd/selftests: Unify error handling

 tools/testing/selftests/vm/userfaultfd.c | 649 ++++++++---------------
 1 file changed, 208 insertions(+), 441 deletions(-)
Signature · 1 line
2.26.2