Skip to content

iommu/tegra-smmu: Add pagetable mappings to debugfs

Nicolin Chen linux-iommu linux-tegra lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest6 patches 16 repliesIn review
  2. v51 patch 5 repliesSuperseded
  3. v41 patch 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v31 patch3 repliesSuperseded
v21 patch4 repliesSuperseded

Changes in v6 from the cover letter · 27 lines

* Added PATCH1-3 for better naming conventions
* Added PATCH4-5 to embed previous struct tegra_smmu_group_debug into struct tegra_smmu_group
* Dropped parentheses at SMMU_PTE_ATTR_SHIFT
* Dropped swgrp->reg print
* Replaced ptb_reg contents with as->attr and as->pd_dma
* Added "index" and "count" in the PD entries for readability
* Removed Dmitry's Tested-by and Reviewed-by for the big change from v5 to v6.
v5: https://lkml.org/lkml/2021/3/15/2473
* Fixed a typo in commit message
* Split a long line into two lines
* Rearranged variable defines by length
* Added Tested-by and Reviewed-by from Dmitry
v4: https://lkml.org/lkml/2021/3/14/429
* Changed %d to %u for unsigned variables
* Fixed print format mismatch warnings on ARM32
v3: https://lkml.org/lkml/2021/3/14/30
* Fixed PHYS and IOVA print formats
* Changed variables to unsigned int type
* Changed the table outputs to be compact
v2: https://lkml.org/lkml/2021/3/9/1382
* Expanded mutex range to the entire function
* Added as->lock to protect pagetable walkthrough
* Replaced devm_kzalloc with devm_kcalloc for group_debug
* Added "PTE RANGE" and "SIZE" columns to group contiguous mappings
* Dropped as->count check
* Added WARN_ON when as->count mismatches pd[pd_index]
v1: https://lkml.org/lkml/2020/9/26/70

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6iommu/tegra-smmu: Rename struct iommu_group *group to *grpdrivers/iommu/tegra-smmu.c+8 -81 reply
2/6iommu/tegra-smmu: Rename struct tegra_smmu_group_soc *soc to *group_socdrivers/iommu/tegra-smmu.c+9 -82 replies
3/6iommu/tegra-smmu: Rename struct tegra_smmu_swgroup *group to *swgrpdrivers/iommu/tegra-smmu.c+17 -172 replies
4/6iommu/tegra-smmu: Use swgrp pointer instead of swgroup iddrivers/iommu/tegra-smmu.c+8 -41 reply
5/6iommu/tegra-smmu: Attach as pointer to tegra_smmu_groupdrivers/iommu/tegra-smmu.c+78 -161 reply
6/6iommu/tegra-smmu: Add pagetable mappings to debugfsdrivers/iommu/tegra-smmu.c+145 -09 replies

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchThierry Reding
1/6A-b
2/6
3/6
4/6A-b
5/6A-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/6] iommu/tegra-smmu: Add pagetable mappings to debugfs

This series of patches adds a new mappings node to debugfs for tegra-smmu driver. The first five patches are all preparational changes for PATCH-6, based on Thierry's review feedback against
v5: https://lkml.org/lkml/2021/3/16/447

Changelog
v6:
* Added PATCH1-3 for better naming conventions
* Added PATCH4-5 to embed previous struct tegra_smmu_group_debug into struct tegra_smmu_group
* Dropped parentheses at SMMU_PTE_ATTR_SHIFT
* Dropped swgrp->reg print
* Replaced ptb_reg contents with as->attr and as->pd_dma
* Added "index" and "count" in the PD entries for readability
* Removed Dmitry's Tested-by and Reviewed-by for the big change from v5 to v6.
v5: https://lkml.org/lkml/2021/3/15/2473
* Fixed a typo in commit message
* Split a long line into two lines
* Rearranged variable defines by length
* Added Tested-by and Reviewed-by from Dmitry
v4: https://lkml.org/lkml/2021/3/14/429
* Changed %d to %u for unsigned variables
* Fixed print format mismatch warnings on ARM32
v3: https://lkml.org/lkml/2021/3/14/30
* Fixed PHYS and IOVA print formats
* Changed variables to unsigned int type
* Changed the table outputs to be compact
v2: https://lkml.org/lkml/2021/3/9/1382
* Expanded mutex range to the entire function
* Added as->lock to protect pagetable walkthrough
* Replaced devm_kzalloc with devm_kcalloc for group_debug
* Added "PTE RANGE" and "SIZE" columns to group contiguous mappings
* Dropped as->count check
* Added WARN_ON when as->count mismatches pd[pd_index]
v1: https://lkml.org/lkml/2020/9/26/70

Nicolin Chen (6):
iommu/tegra-smmu: Rename struct iommu_group *group to *grp iommu/tegra-smmu: Rename struct tegra_smmu_group_soc *soc to
*group_soc
iommu/tegra-smmu: Rename struct tegra_smmu_swgroup *group to *swgrp iommu/tegra-smmu: Use swgrp pointer instead of swgroup id iommu/tegra-smmu: Attach as pointer to tegra_smmu_group iommu/tegra-smmu: Add pagetable mappings to debugfs

 drivers/iommu/tegra-smmu.c | 312 +++++++++++++++++++++++++++++++------
 1 file changed, 262 insertions(+), 50 deletions(-)
Signature · 1 line
2.17.1