PCI Data Object Exchange support + CXL CDAT
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 9 repliesIn review
- v3 RFC4 patches 26 repliesSuperseded
- v2 RFC4 patches 6 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 RFC | 2 patches | 17 replies | Superseded |
Changes in v4 from the cover letter
Thanks to Ira, Bjorn and Dan for feedback.
* Addition of a generic IOCTL interface and demo program for discussion.
* Fixed an issue with accidentally disabling interrupts.
* Ensure IRQ_HANDLED always returned as clearing of BUSY can result in an interrupt, but there is no means of identifying this. The best that can be done is to eat the interrupt.
* Edited comments to more directly tie them to the code the referred to.
* Lock scope documentation update.
* Dropped the CDAT dump to log patch as we are hopefully getting closer to this being applied.
* Fixed the references to pcie_ missed when renaming to pci_ in v3.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | PCI: Add vendor ID for the PCI SIGinclude/ | +1 | 3 replies | |
| 2/5 | PCI/DOE: Add Data Object Exchange supportdrivers/ drivers/ drivers/ +3 more | +753 | 4 replies | |
| 3/5 | cxl/mem: Add CDAT table reading from DOEdrivers/ drivers/ drivers/ +1 more | +202 | 1 reply | |
| 4/5 | DONOTMERGE: PCI/DOE: Add per DOE chrdev for ioctl based accessdrivers/ drivers/ include/ +1 more | +225 | 0 replies | |
| 5/5 | DONOTMERGE: PCI/DOE: Add userspace example program to tools/pcitools/ tools/ tools/ | +140 | 0 replies |
Reviews trailers per patch
1 of 5 patches has a Reviewed-by or Acked-by.
| Patch | Dan Williams |
|---|---|
| 1/5 | R-b |
| 2/5 | |
| 3/5 | |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/5] PCI Data Object Exchange support + CXL CDAT
Series first introduces generic support for DOE mailboxes as defined in the ECN to the PCIe r5.0 specification available from the PCI SIG [0]
A user is then introduced in the form of the table access protocol defined in the CXL 2.0 specification [1] used to access the
Coherent Device Attribute Table (CDAT) defined in [2]
Finally, in two patches that are not intended for merging, an example of a generic IOCTL interface to perform synchronous exchanges from user space in a kernel mediated fashion is introduced. The current consensus seems in favour of not introducing such an interface, but instead providing per protocol interfaces where appropriate. As this code was developed in parallel with that discussion and may be of use to someone it is included here.
Open questions.
* Do we need to prevent userspace access to the DOE when the kernel is managing it (registered by driver)? Discussion in thread:
https://lore.kernel.org/linux-pci/[email protected]/
* Does a generic userspace mediation interface make sense? Currently it seems not, but as it was nearly ready, I've included it in this patch set anyway.
* Move CXL cdat handling to a separate file, or wait until we can see how it is going to be used?
Changes since v3
Thanks to Ira, Bjorn and Dan for feedback.
* Addition of a generic IOCTL interface and demo program for discussion.
* Fixed an issue with accidentally disabling interrupts.
* Ensure IRQ_HANDLED always returned as clearing of BUSY can result in an interrupt, but there is no means of identifying this. The best that can be done is to eat the interrupt.
* Edited comments to more directly tie them to the code the referred to.
* Lock scope documentation update.
* Dropped the CDAT dump to log patch as we are hopefully getting closer to this being applied.
* Fixed the references to pcie_ missed when renaming to pci_ in v3.
Set based on cxl/next
All testing conducted against QEMU emulation of a CXL type 3 device in conjunction with DOE mailbox patches v5 [3, 4]
[0] https://pcisig.com/specifications
[1] https://www.computeexpresslink.org/download-the-specification
[2] https://uefi.org/node/4093
[3] https://lore.kernel.org/qemu-devel/[email protected]/
[4] https://lore.kernel.org/qemu-devel/[email protected]/
Jonathan Cameron (5):
PCI: Add vendor ID for the PCI SIG
PCI/DOE: Add Data Object Exchange support
cxl/mem: Add CDAT table reading from DOE
DONOTMERGE PCI/DOE Add per DOE chrdev for ioctl based access
DONOTMERGE: PCI/DOE: Add userspace example program to tools/pci
drivers/cxl/Kconfig | 1 + drivers/cxl/cxl.h | 21 + drivers/cxl/mem.c | 174 ++++++++ drivers/cxl/mem.h | 6 + drivers/pci/Kconfig | 8 + drivers/pci/Makefile | 1 + drivers/pci/doe.c | 794 ++++++++++++++++++++++++++++++++++ drivers/pci/pci-driver.c | 3 +- include/linux/pci-doe.h | 100 +++++ include/linux/pci.h | 3 + include/linux/pci_ids.h | 1 + include/uapi/linux/pci_doe.h | 32 ++ include/uapi/linux/pci_regs.h | 29 +- tools/pci/Build | 1 + tools/pci/Makefile | 9 +- tools/pci/doetest.c | 131 ++++++ 16 files changed, 1311 insertions(+), 3 deletions(-) create mode 100644 drivers/pci/doe.c create mode 100644 include/linux/pci-doe.h create mode 100644 include/uapi/linux/pci_doe.h create mode 100644 tools/pci/doetest.c
base-commit: 35c32e3095d396c750f5cdfdaa94cba83d9b23c6
Signature · 1 line
2.19.1