Skip to content

Fix RCU warnings in TDP MMU

Ben Gardon kvm lkml 3 versions – Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 3 repliesApplied
  2. v24 patches 3 repliesSuperseded
  3. v14 patches 9 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4KVM: x86/mmu: Fix RCU usage in handle_removed_tdp_mmu_pagearch/x86/kvm/mmu/tdp_mmu.c+8 -30 replies
2/4KVM: x86/mmu: Fix RCU usage when atomically zapping SPTEsarch/x86/kvm/mmu/tdp_mmu.c+1 -11 reply
3/4KVM: x86/mmu: Factor out tdp_iter_return_to_rootarch/x86/kvm/mmu/tdp_iter.c arch/x86/kvm/mmu/tdp_iter.h arch/x86/kvm/mmu/tdp_mmu.c+19 -101 reply
4/4KVM: x86/mmu: Store the address space ID in the TDP iteratorarch/x86/kvm/mmu/mmu_internal.h arch/x86/kvm/mmu/tdp_iter.c arch/x86/kvm/mmu/tdp_iter.h +1 more+13 -240 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchSean Christopherson
1/4
2/4R-b
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] Fix RCU warnings in TDP MMU

The Linux Test Robot found a few RCU warnings in the TDP MMU:
https://www.spinics.net/lists/kernel/msg3845500.html
https://www.spinics.net/lists/kernel/msg3845521.html

Fix these warnings and cleanup a hack in tdp_mmu_iter_cond_resched.

Tested by compiling as suggested in the test robot report and confirmed that the warnings go away with this series applied. Also ran kvm-unit-tests on an Intel Skylake machine with the TDP MMU enabled and confirmed that the series introduced no new failures.

Ben Gardon (3):
KVM: x86/mmu: Fix RCU usage in handle_removed_tdp_mmu_page
KVM: x86/mmu: Fix RCU usage when atomically zapping SPTEs
KVM: x86/mmu: Factor out tdp_iter_return_to_root

Sean Christopherson (1):
KVM: x86/mmu: Store the address space ID in the TDP iterator

 arch/x86/kvm/mmu/mmu_internal.h |  5 +++++
 arch/x86/kvm/mmu/tdp_iter.c     | 30 +++++++++++++++----------
 arch/x86/kvm/mmu/tdp_iter.h     |  4 +++-
 arch/x86/kvm/mmu/tdp_mmu.c      | 40 +++++++++++++--------------------
 4 files changed, 41 insertions(+), 38 deletions(-)
Signature · 1 line
2.31.0.rc2.261.g7f71774620-goog