Skip to content

x86,objtool: Optimize !RETPOLINE

Peter Zijlstra lkml 3 versions – Applied

Status from this message: The following commit has been merged into the x86/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest16 patches 34 repliesApplied
  2. v214 patches 30 repliesSuperseded
  3. v19 patches 18 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/16x86: Add insn_decode_kernel()arch/x86/include/asm/insn.h arch/x86/kernel/alternative.c arch/x86/kernel/cpu/mce/severity.c +4 more+10 -60 replies
2/16x86/alternatives: Optimize optimize_nops()arch/x86/include/asm/alternative.h arch/x86/kernel/alternative.c tools/objtool/arch/x86/include/arch/special.h+33 -280 replies
3/16x86/retpoline: Simplify retpolinesarch/x86/include/asm/asm-prototypes.h arch/x86/include/asm/nospec-branch.h arch/x86/lib/retpoline.S +1 more+21 -291 reply
4/16objtool: Correctly handle retpoline thunk callstools/objtool/check.c+12 -00 replies
5/16objtool: Per arch retpoline namingtools/objtool/arch/x86/decode.c tools/objtool/check.c tools/objtool/include/objtool/arch.h+14 -20 replies
6/16objtool: Fix static_call list generationtools/objtool/check.c+12 -50 replies
7/16objtool: Rework rebuild_reloc logictools/objtool/check.c tools/objtool/elf.c tools/objtool/include/objtool/elf.h +1 more+14 -160 replies
8/16objtool: Add elf_create_reloc() helpertools/objtool/check.c tools/objtool/elf.c tools/objtool/include/objtool/elf.h +1 more+85 -1190 replies
9/16objtool: Implicitly create reloc sectionstools/objtool/check.c tools/objtool/elf.c tools/objtool/include/objtool/elf.h +1 more+8 -100 replies
10/16objtool: Extract elf_strtab_concat()tools/objtool/elf.c+38 -220 replies
11/16objtool: Extract elf_symbol_add()tools/objtool/elf.c+31 -250 replies
12/16objtool: Add elf_create_undef_symbol()tools/objtool/elf.c tools/objtool/include/objtool/elf.h+61 -00 replies
13/16objtool: Keep track of retpoline call sitestools/objtool/check.c tools/objtool/include/objtool/arch.h tools/objtool/include/objtool/check.h +2 more+34 -60 replies
14/16objtool: Cache instruction relocstools/objtool/check.c tools/objtool/include/objtool/check.h+23 -60 replies
15/16objtool: Skip magical retpoline .altinstr_replacementtools/objtool/special.c+11 -10 replies
16/16objtool,x86: Rewrite retpoline thunk callsarch/x86/include/asm/asm-prototypes.h arch/x86/lib/retpoline.S tools/objtool/arch/x86/decode.c+168 -332 replies

Reviews trailers per patch

None of the 16 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMiroslav BenesNick DesaulniersNathan Chancellor
SeriesR-b
1/16
2/16
3/16
4/16
5/16
6/16
7/16
8/16
9/16
10/16
11/16
12/16
13/16
14/16
15/16
16/16T-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/16] x86,objtool: Optimize !RETPOLINE

Hi, another week, another update :-)

Respin of the !RETPOLINE optimization patches.

Boris, the first 3 should probably go into tip/x86/core, it's an ungodly tangle since it relies on the insn decoder patches in tip/x86/core, the NOP patches in tip/x86/cpu and the alternative patches in tip/x86/alternatives.

Just to make life easy I'd suggest merging everything in x86/core and forgetting about the other topic branches (that's what I ended up doing locally).

The remaining 13 patches depend on the first 3 as well as on the work in tip/objtool/core, just to make life more interesting still ;-)

All except the last 4 patches should be fairly uncontroversial (I hope...).

There's a fair number of new patches and another few have been completely rewritten, but it all seems to work nicely.