Skip to content

KVM: x86: nSVM: fixes for SYSENTER emulation

Maxim Levitsky kvm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2KVM: x86: add guest_cpuid_is_intelarch/x86/kvm/cpuid.h+8 -00 replies
2/2KVM: nSVM: improve SYSENTER emulation on AMDarch/x86/kvm/svm/svm.c arch/x86/kvm/svm/svm.h+69 -354 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] KVM: x86: nSVM: fixes for SYSENTER emulation

This is a result of deep rabbit hole dive in regard to why currently the nested migration of 32 bit guests is totally broken on AMD.

It turns out that due to slight differences between the original AMD64 implementation and the Intel's remake, SYSENTER instruction behaves a bit differently on Intel, and to support migration from Intel to AMD we try to emulate those differences away.

Sadly that collides with virtual vmload/vmsave feature that is used in nesting such as on migration (and otherwise when userspace
reads MSR_IA32_SYSENTER_EIP/MSR_IA32_SYSENTER_ESP), wrong value is returned, which leads to #DF in the nested guest when the wrong value is loaded back.

The patch I prepared carefully fixes this, by mostly disabling that SYSCALL emulation when we don't spoof Intel's vendor ID, and if we do, and yet somehow SVM is enabled (this is very rare corner case), then virtual vmload/save is force disabled.

Best regards,
Maxim Levitsky

Maxim Levitsky (2):
KVM: x86: add guest_cpuid_is_intel
KVM: nSVM: improve SYSENTER emulation on AMD

 arch/x86/kvm/cpuid.h   |  8 ++++
 arch/x86/kvm/svm/svm.c | 97 ++++++++++++++++++++++++++++--------------
 arch/x86/kvm/svm/svm.h |  7 +--
 3 files changed, 77 insertions(+), 35 deletions(-)
Signature · 1 line
2.26.2