Skip to content

gpio: sch: Interrupt support

Andy Shevchenko linux-gpio lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 4 repliesIn review
  2. v42 patches 5 repliesSuperseded

Changes in v5 from the cover letter

- added missed IRQ acknowledge callback (hence kernel Oops)
- rewrite patch 2 completely from SCI to GPE hook

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2gpio: sch: Add edge event supportdrivers/gpio/gpio-sch.c+106 -82 replies
2/2gpio: sch: Hook into ACPI GPE handler to catch GPIO edge eventsdrivers/gpio/gpio-sch.c+82 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchLinus Walleij
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/2] gpio: sch: Interrupt support

The series adds event support to the Intel GPIO SCH driver. The hardware routes all events through GPE0 GPIO event.

I validated this on Intel Minnowboard (v1).

If somebody has different hardware with the same GPIO controller, I would appreciate additional testing.

Changes in v5:
- added missed IRQ acknowledge callback (hence kernel Oops)
- rewrite patch 2 completely from SCI to GPE hook

Changes in v4 (https://lore.kernel.org/linux-gpio/[email protected]/T/#u):
- turned to GPIO core infrastructure of IRQ chip instantiation (Linus)
- converted IRQ callbacks to use better APIs
- use handle_bad_irq() as default handler and now I know why, see
eb441337c714 ("gpio: pca953x: Set IRQ type when handle Intel Galileo Gen 2")
for the real example what happens if it's preset to something meaningful
- fixed remove stage (we have to remove SCI handler, which wasn't done in v3)

Changes in v3 (https://lore.kernel.org/linux-gpio/[email protected]/T/#u):
- split-up of the irq enabling patch as requested by Andy

Andy Shevchenko (1):
gpio: sch: Hook into ACPI GPE handler to catch GPIO edge events

Jan Kiszka (1):
gpio: sch: Add edge event support

 drivers/gpio/gpio-sch.c | 196 ++++++++++++++++++++++++++++++++++++++--
 1 file changed, 188 insertions(+), 8 deletions(-)
Signature · 1 line
2.30.2