Skip to content

KVM: x86: MSR filtering and related fixes

Sean Christopherson kvm lkml 4 versions – Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 1 replyApplied
  2. v33 patches 3 repliesSuperseded
  3. v24 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches9 repliesSuperseded

Changes in v4 from the cover letter

- Rebase to 0d7d84498fb4 ("KVM: x86: SGX must obey the ... protocol")
- Fix inverted passthrough check for SPEC_CTRL. [Vitaly]
- Add patch to fix MSR bitmap enabling check in helper.

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/4KVM: nVMX: Query current VMCS when determining if MSR bitmaps are in usearch/x86/kvm/vmx/vmx.c+4 -40 replies
2/4KVM: nVMX: Handle dynamic MSR intercept togglingarch/x86/kvm/vmx/nested.c arch/x86/kvm/vmx/vmx.c arch/x86/kvm/vmx/vmx.h+115 -1140 replies
3/4KVM: VMX: Macrofy the MSR bitmap getters and settersarch/x86/kvm/vmx/vmx.h+17 -600 replies
4/4KVM: nVMX: Clean up x2APIC MSR handling for L2arch/x86/kvm/vmx/nested.c arch/x86/kvm/vmx/vmx.h+22 -390 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/4] KVM: x86: MSR filtering and related fixes

Fix a nVMX MSR interception check bug, fix two intertwined nVMX bugs bugs related to MSR filtering (one directly, one indirectly), and additional cleanup on top. The main SRCU fix from the original series was merged, but these got left behind (luckily, becaues the main fix was buggy).

Side topic, getting a VM to actually barf on RDMSR(SPEC_CTRL) is comically
difficult: -spec-ctrl,-stibp,-ssbd,-ibrs-all,-ibpb,-amd-stibp,-amd-ssbd. QEMU and KVM really, really want to expose SPEC_CTRL to the guest :-)

v4:
- Rebase to 0d7d84498fb4 ("KVM: x86: SGX must obey the ... protocol")
- Fix inverted passthrough check for SPEC_CTRL. [Vitaly]
- Add patch to fix MSR bitmap enabling check in helper.

v3:
- Rebase to 9f6090b09d66 ("KVM: MMU: make spte .... in make_spte")

v2:
- https://lkml.kernel.org/r/[email protected]
- Make the macro insanity slightly less insane. [Paolo]

v1: https://lkml.kernel.org/r/[email protected]

Sean Christopherson (4):
KVM: nVMX: Query current VMCS when determining if MSR bitmaps are in
use
KVM: nVMX: Handle dynamic MSR intercept toggling
KVM: VMX: Macrofy the MSR bitmap getters and setters
KVM: nVMX: Clean up x2APIC MSR handling for L2

 arch/x86/kvm/vmx/nested.c | 164 +++++++++++++++-----------------------
 arch/x86/kvm/vmx/vmx.c    |  61 ++------------
 arch/x86/kvm/vmx/vmx.h    |  28 +++++++
 3 files changed, 97 insertions(+), 156 deletions(-)
Signature · 1 line
2.34.0.rc0.344.g81b53c2807-goog