USB: cdc-acm: probe fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest8 patches 1 replyIn review
- v17 patches 8 repliesSuperseded
Changes in v2 from the cover letter
- clarify that the driver already had a check for a bound data interface and remove the now redundant check (Oliver) (7/8)
- add Oliver's ack to patches 1 through 6
- add new to avoid logging a successful probe message on late errors (8/8)
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | USB: cdc-acm: fix double free on probe failuredrivers/ | +0 | 0 replies | |
| 2/8 | USB: cdc-acm: fix use-after-free after probe failuredrivers/ | +5 | 0 replies | |
| 3/8 | USB: cdc-acm: drop redundant driver-data assignmentdrivers/ | +0 | 0 replies | |
| 4/8 | USB: cdc-acm: drop redundant driver-data resetdrivers/ | +0 | 0 replies | |
| 5/8 | USB: cdc-acm: clean up probe error labelsdrivers/ | +18 | 0 replies | |
| 6/8 | USB: cdc-acm: use negation for NULL checksdrivers/ | +2 | 0 replies | |
| 7/8 | USB: cdc-acm: always claim data interfacedrivers/ | +6 | 0 replies | |
| 8/8 | USB: cdc-acm: do not log successful probe on later errorsdrivers/ | +2 | 0 replies |
Reviews trailers per patch
6 of 8 patches have a Reviewed-by or Acked-by.
| Patch | Oliver Neukum |
|---|---|
| 1/8 | A-b |
| 2/8 | A-b |
| 3/8 | A-b |
| 4/8 | A-b |
| 5/8 | A-b |
| 6/8 | A-b |
| 7/8 | |
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/8] USB: cdc-acm: probe fixes
This series fixes a couple of bugs in the probe errors paths and does some clean up in preparation for adding the missing error handling when claiming the data interface.
The first two should probably go into 5.12-rc, while the rest could be held off for 5.13 if preferred.
Johan
Changes in v2
- clarify that the driver already had a check for a bound data interface and remove the now redundant check (Oliver) (7/8)
- add Oliver's ack to patches 1 through 6
- add new to avoid logging a successful probe message on late errors (8/8)
Johan Hovold (8):
USB: cdc-acm: fix double free on probe failure
USB: cdc-acm: fix use-after-free after probe failure
USB: cdc-acm: drop redundant driver-data assignment
USB: cdc-acm: drop redundant driver-data reset
USB: cdc-acm: clean up probe error labels
USB: cdc-acm: use negation for NULL checks
USB: cdc-acm: always claim data interface
USB: cdc-acm: do not log successful probe on later errors
drivers/usb/class/cdc-acm.c | 65 +++++++++++++++++++------------------ 1 file changed, 33 insertions(+), 32 deletions(-)
Signature · 1 line
2.26.3