KVM: x86/mmu: Fix TLB flushing bugs in TDP MMU
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 7 repliesIn review
- v12 patches 7 repliesSuperseded
Changes in v2 from the cover letter
- Collect a review. [Ben]
- Disallowing yielding instead of feeding "flush" into the TDP MMU. [Ben]
- Move the yielding logic to a separate patch since it's not strictly a bug fix and it's standalone anyways (the flush feedback loop was not).
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | KVM: x86/mmu: Ensure TLBs are flushed when yielding during GFN range zaparch/ | +12 | 0 replies | |
| 2/3 | KVM: x86/mmu: Ensure TLBs are flushed for TDP MMU during NX zappingarch/ | +7 | 1 reply | |
| 3/3 | KVM: x86/mmu: Don't allow TDP MMU to yield when recovering NX pagesarch/ arch/ arch/ | +26 | 6 replies |
Reviews trailers per patch
2 of 3 patches have a Reviewed-by or Acked-by.
| Patch | Ben Gardon |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/3] KVM: x86/mmu: Fix TLB flushing bugs in TDP MMU
Two bug fixes and a clean up involving the TDP MMU, found by inspection.
Patch 1 fixes a bug where KVM yields, e.g. due to lock contention, without performing a pending TLB flush that was required from a previous root.
Patch 2 fixes a much more egregious bug where it fails to handle TDP MMU flushes in NX huge page recovery.
Patch 3 explicitly disallows yielding in the TDP MMU to prevent a similar bug to patch 1 from sneaking in.
v2:
- Collect a review. [Ben]
- Disallowing yielding instead of feeding "flush" into the TDP MMU. [Ben]
- Move the yielding logic to a separate patch since it's not strictly a bug fix and it's standalone anyways (the flush feedback loop was not).
v1:
- https://lkml.kernel.org/r/[email protected]
Sean Christopherson (3):
KVM: x86/mmu: Ensure TLBs are flushed when yielding during GFN range
zap
KVM: x86/mmu: Ensure TLBs are flushed for TDP MMU during NX zapping
KVM: x86/mmu: Don't allow TDP MMU to yield when recovering NX pages
arch/x86/kvm/mmu/mmu.c | 9 +++++---- arch/x86/kvm/mmu/tdp_mmu.c | 26 ++++++++++++++------------ arch/x86/kvm/mmu/tdp_mmu.h | 23 ++++++++++++++++++++++- 3 files changed, 41 insertions(+), 17 deletions(-)
Signature · 1 line
2.31.0.291.g576ba9dcdaf-goog